Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wavetable morph lag adjustment #7783

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

blancoberg
Copy link
Contributor

Wavetable morph lag for modulations has been removed.

Morph lag has been removed for all modulations as it is not needed with the improved interpolation lerp.
The lag is still there for handling the ui interactions and daw automations. ( unmodulated value of the parameter )

Related #7696

Wavetable morph lag has been removed for modulations but is still in place for ui interactions & daw automations
@baconpaul
Copy link
Collaborator

I’m sorry Joel I didn’t get to this today

@blancoberg
Copy link
Contributor Author

I’m sorry Joel I didn’t get to this today

No stress at all Paul!

Copy link
Collaborator

@baconpaul baconpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really lovely work Joel

One comment I couldn't understand but the rest of it looks correct to me.

src/common/dsp/SurgeVoice.h Outdated Show resolved Hide resolved
Removed copyParametersToLocal() declaration as it is not used anymore.
@baconpaul baconpaul merged commit d94d252 into surge-synthesizer:main Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants