Fix a LUA stack leak with a missing init fn in wtse (#7889)

Oops! If I get a nil I still need to pop it.
surge-synthesizer · Dec 1, 2024 · f6274e6 · f6274e6
1 parent 03373f9
commit f6274e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/common/LuaSupport.cpp b/src/common/LuaSupport.cpp
@@ -315,6 +315,10 @@ Surge::LuaSupport::SGLD::~SGLD()
         {
             std::cout << "Guarded stack leak: [" << label << "] exit=" << nt << " enter=" << top
                       << std::endl;
+            for (int i = nt; i >= top; i--)
+            {
+                std::cout << "  " << i << " -> " << lua_typename(L, lua_type(L, i)) << std::endl;
+            }
         }
 #endif
     }

diff --git a/src/common/dsp/WavetableScriptEvaluator.cpp b/src/common/dsp/WavetableScriptEvaluator.cpp
@@ -75,6 +75,7 @@ struct LuaWTEvaluator::Details
         lua_getglobal(L, "init");
         if (!lua_isfunction(L, -1))
         {
+            lua_pop(L, -1);
             makeEmptyState(true);
         }
         else