Use emplace to eliminate move/copy operations. (#7861)

* Use emplace to eliminate move/copy operations. * Don't modify third party shipped code --------- Co-authored-by: David Lowndes <David@DAVIDPCZ> Co-authored-by: Paul Walker <[email protected]>
surge-synthesizer · Nov 21, 2024 · 9ad1f54 · 9ad1f54
1 parent 2b2edda
commit 9ad1f54
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/common/SkinModelImpl.cpp b/src/common/SkinModelImpl.cpp
@@ -286,7 +286,7 @@ std::vector<Connector> Connector::connectorsByComponentType(const Component &c)
     for (auto it : *idmap)
     {
         if (it.second->defaultComponent == c)
-            res.push_back(Connector(it.second));
+            res.emplace_back(Connector(it.second));
     }
     return res;
 }

diff --git a/src/surge-testrunner/UnitTestsLUA.cpp b/src/surge-testrunner/UnitTestsLUA.cpp
@@ -448,7 +448,7 @@ std::vector<formulaObservation> runFormula(SurgeStorage *storage, FormulaModulat
 
         float r[Surge::Formula::max_formula_outputs];
         Surge::Formula::valueAt(iphase, phase, storage, fs, &es, r);
-        res.push_back(formulaObservation(iphase, phase, r[0]));
+        res.emplace_back(formulaObservation(iphase, phase, r[0]));
         for (int i = 0; i < Surge::Formula::max_formula_outputs; ++i)
             res.back().vVec[i] = r[i];
 

diff --git a/src/surge-testrunner/UnitTestsMSEG.cpp b/src/surge-testrunner/UnitTestsMSEG.cpp
@@ -61,7 +61,7 @@ std::vector<msegObservation> runMSEG(MSEGStorage *ms, float dPhase, float phaseM
         es.released = release;
 
         auto r = Surge::MSEG::valueAt(iphase, phase, deform, ms, &es, false);
-        res.push_back(msegObservation(iphase, phase, r));
+        res.emplace_back(msegObservation(iphase, phase, r));
         phase += dPhase;
         if (phase > 1)
         {