-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Обновление BrightSide #81
Open
Stampoo
wants to merge
9
commits into
master
Choose a base branch
from
Update-BrightSide-utility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c887977
Add new dir on check jailbreak
Stampoo ef80894
Merge branch 'master' into Update-BrightSide-utility
KASAFF 8397abb
SNP-1864 update brightside, fix logic, add more directories
KASAFF 788179c
SNP-1864 add more sus directories
KASAFF 78433e5
SNP-1864 add more urls to writing checks
KASAFF ca4a25b
SNP-1864 refactor check 4
KASAFF 66741a6
SNP-1864 refactor imports
KASAFF 569155d
SNP-1864 refactor import
KASAFF 29b5a3b
SNP-1864 move simulator checks from first to last
KASAFF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а тут логика точно не поменялась? раньше, получается, true возвращалось если хотя бы по одному из путей файл был, ну и в комменте так и указано к методу) а теперь - true ведь будет, если allSatisfy? -_-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
как помню из переписки - Илья сказал что да, косяк есть, но он хотел покрыть тестами, чтобы получить ошибку на них, и исправить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправил