Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schnorr's DLog PoK #11
Schnorr's DLog PoK #11
Changes from all commits
8326e2a
c1841ac
a33d11e
2808bfd
0af2624
b5195de
e2a61f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper Markdown formatting by adding a blank line after the heading.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the duplicated "References" heading.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the bare URL with a descriptive link text to improve readability and accessibility.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
unwrap()
on the conversion frombigint
toScalarField
could lead to a panic if the conversion fails. Consider handling this potential error more gracefully to improve the robustness of the code.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test
schnorr_dlog_pok
appears to be well-structured and tests the basic functionality of the Schnorr DLog PoK implementation. Ensure that edge cases and error conditions are also tested to improve the test coverage.Would you like me to help by adding additional test cases or improving the existing ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supragya, I'm glad to help! Here are some additional test cases for the Schnorr DLog PoK implementation that cover edge cases and error conditions:
Here's the additional test code:
These tests should help improve the robustness and coverage of your Schnorr DLog PoK implementation. Let me know if there's anything else you'd like to add or modify!