Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serialize claim refresh calls #254

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

porcellus
Copy link
Collaborator

Summary of change

serialize claim refresh calls during validateClaims

Related issues

Test Plan

Added new tests:

  • It should only call refresh once even for concurrent validateClaims calls
  • It should retry the refresh call if it returns a 401
  • It should work even if there is a network error when refreshing
  • It should work (and proceed with validation) even if it runs out of retries for acquiring the lock (SKIPPED)

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
lib/build/bundleEntry.js 20.38 KB (+1.14% 🔺)

@porcellus porcellus merged commit 77923ce into 20.0 May 22, 2024
4 checks passed
@porcellus porcellus deleted the feat/serialize_claim_refreshing branch May 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant