Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attemptRefreshingSession should not throw if the refresh call 401s #246

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

fix: attemptRefreshingSession should not throw if the refresh call 401s

Related issues

Test Plan

Added 2 related test:

  1. Test that attemptRefreshingSession doesn't throw in this situation (this fails on master)
  2. Test that sessionDoesNotExist doesn't throw in this situation (this already passes on master)

Documentation changes

N/A, bugfix

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

github-actions bot commented Feb 6, 2024

size-limit report 📦

Path Size
lib/build/bundleEntry.js 20.19 KB (0%)

@rishabhpoddar rishabhpoddar merged commit 7dce5be into 18.0 Feb 6, 2024
4 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/attemptRefreshingSession_throwing branch February 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants