refactor: updated/commented leftover Date.now calls

supertokens · Jan 17, 2024 · fe671df · fe671df
1 parent c0627b4
commit fe671df
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/bundle/bundle.js b/bundle/bundle.js
diff --git a/lib/build/fetch.js b/lib/build/fetch.js
diff --git a/lib/build/recipeImplementation.js b/lib/build/recipeImplementation.js
diff --git a/lib/ts/fetch.ts b/lib/ts/fetch.ts
@@ -671,6 +671,7 @@ export function setToken(tokenType: TokenType, value: string) {
     if (value !== "") {
         logDebugMessage(`setToken: saved ${tokenType} token into cookies`);
         // We save the tokens with a 100-year expiration time
+        // We have to use the client side system clock here, because the cookie expiration will be counted based on that
         return storeInCookies(name, value, Date.now() + 3153600000);
     } else {
         logDebugMessage(`setToken: cleared ${tokenType} token from cookies`);
@@ -786,6 +787,7 @@ async function saveTokensFromHeaders(response: Response) {
 export async function saveLastAccessTokenUpdate() {
     logDebugMessage("saveLastAccessTokenUpdate: called");
 
+    // We are saving the client side time here, but the actual value doesn't matter.
     const now = Date.now().toString();
     logDebugMessage("saveLastAccessTokenUpdate: setting " + now);
     await storeInCookies(LAST_ACCESS_TOKEN_UPDATE, now, Number.MAX_SAFE_INTEGER);

diff --git a/lib/ts/recipeImplementation.ts b/lib/ts/recipeImplementation.ts
@@ -14,6 +14,7 @@ import { logDebugMessage } from "./logger";
 import { STGeneralError } from "./error";
 import { addInterceptorsToXMLHttpRequest } from "./xmlhttprequest";
 import { normaliseSessionScopeOrThrowError, normaliseURLDomainOrThrowError } from "./utils";
+import DateProviderReference from "./utils/dateProvider";
 
 export default function RecipeImplementation(recipeImplInput: {
     preAPIHook: RecipePreAPIHookFunction;
@@ -99,7 +100,7 @@ export default function RecipeImplementation(recipeImplInput: {
                 throw new Error("No session exists");
             }
 
-            if (tokenInfo.ate < Date.now()) {
+            if (tokenInfo.ate < DateProviderReference.getReferenceOrThrow().dateProvider.now()) {
                 logDebugMessage("getAccessTokenPayloadSecurely: access token expired. Refreshing session");
                 let retry = await AuthHttpRequest.attemptRefreshingSession();
                 if (retry) {
@@ -124,7 +125,7 @@ export default function RecipeImplementation(recipeImplInput: {
                 return false;
             }
 
-            if (tokenInfo.ate < Date.now()) {
+            if (tokenInfo.ate < DateProviderReference.getReferenceOrThrow().dateProvider.now()) {
                 logDebugMessage("doesSessionExist: access token expired. Refreshing session");
 
                 const preRequestLSS = await getLocalSessionState(false);