Skip to content

Commit

Permalink
fix(claim_validator): Update the same id claim validator instead of a…
Browse files Browse the repository at this point in the history
…dding a new one
  • Loading branch information
AmanAgarwal041 committed Dec 13, 2024
1 parent 9fb59d5 commit b11ad92
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

- Updated the `SessionClaimValidatorStore.addClaimValidatorFromOtherRecipe` function to update the claimValidator to the latest if added again with the same id instead of adding a new claimValidator.

## [20.1.5] - 2024-10-03

### Changes
Expand Down
2 changes: 1 addition & 1 deletion bundle/bundle.js

Large diffs are not rendered by default.

19 changes: 18 additions & 1 deletion lib/build/utils/sessionClaimValidatorStore.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion lib/ts/utils/sessionClaimValidatorStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,25 @@ export class SessionClaimValidatorStore {
private static claimValidatorsAddedByOtherRecipes: SessionClaimValidator[] = [];

static addClaimValidatorFromOtherRecipe = (builder: SessionClaimValidator) => {
SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.push(builder);
let existingBuilderIdIndex: number = -1;
SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.forEach((claimValidator, index) => {
if (claimValidator.id === builder.id) {
existingBuilderIdIndex = index;
}
});

/*
* Updating the claim validator in the claimValidatorsAddedByOtherRecipes list if the
* validator already exists with the same builder id else we push the new builder in
* the claimValidatorsAddedByOtherRecipes.
* Hence, always the last added claim validator for the recipe will exist in the
* claimValidatorsAddedByOtherRecipes list.
*/
if (existingBuilderIdIndex > -1) {
SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes[existingBuilderIdIndex] = builder;
} else {
SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.push(builder);
}
};

static getClaimValidatorsAddedByOtherRecipes = (): SessionClaimValidator[] => {
Expand Down

0 comments on commit b11ad92

Please sign in to comment.