PR changes

supertokens · Jan 23, 2024 · 739ec29 · 739ec29
1 parent ccbaf03
commit 739ec29
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 16 deletions.
diff --git a/bundle/bundle.js b/bundle/bundle.js
diff --git a/lib/build/claims/primitiveArrayClaim.js b/lib/build/claims/primitiveArrayClaim.js
diff --git a/lib/build/claims/primitiveClaim.js b/lib/build/claims/primitiveClaim.js
diff --git a/lib/build/utils/dateProvider/defaultImplementation.js b/lib/build/utils/dateProvider/defaultImplementation.js
diff --git a/lib/ts/claims/primitiveArrayClaim.ts b/lib/ts/claims/primitiveArrayClaim.ts
@@ -39,7 +39,7 @@ export class PrimitiveArrayClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
 
@@ -91,7 +91,7 @@ export class PrimitiveArrayClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
                     return (
@@ -146,7 +146,7 @@ export class PrimitiveArrayClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
                     return (
@@ -198,7 +198,7 @@ export class PrimitiveArrayClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
 
@@ -255,7 +255,7 @@ export class PrimitiveArrayClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
 

diff --git a/lib/ts/claims/primitiveClaim.ts b/lib/ts/claims/primitiveClaim.ts
@@ -39,7 +39,7 @@ export class PrimitiveClaim<ValueType> {
                 shouldRefresh: (payload, ctx) => {
                     if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
-                            `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
+                            `maxAgeInSeconds must be greater than or equal to the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`
                         );
                     }
                     return (

diff --git a/lib/ts/utils/dateProvider/defaultImplementation.ts b/lib/ts/utils/dateProvider/defaultImplementation.ts
@@ -68,7 +68,7 @@ export class DateProvider {
     }
 
     setClientClockSkewInMillis(clockSkewInMillis: number): void {
-        this.clockSkewInMillis = Math.abs(clockSkewInMillis) > this.thresholdInSeconds * 1000 ? clockSkewInMillis : 0;
+        this.clockSkewInMillis = Math.abs(clockSkewInMillis) >= this.thresholdInSeconds * 1000 ? clockSkewInMillis : 0;
         const localStorage = WindowHandlerReference.getReferenceOrThrow().windowHandler.localStorage;
         localStorage.setItemSync(DateProvider.CLOCK_SKEW_KEY, String(clockSkewInMillis));
     }

diff --git a/test/sessionClaimValidatorRefresh.test.js b/test/sessionClaimValidatorRefresh.test.js
@@ -35,7 +35,7 @@ function withFakeClock(now, cb) {
 describe("SessionClaimValidator Refresh", () => {
     jsdom({ url: "http://localhost" });
 
-    describe("SessionClaimValidator Instantiation ", () => {
+    describe("SessionClaimValidator:shouldRefresh", () => {
         before(function () {
             WindowHandlerReference.init();
             DateProviderReference.init();