removes try catch from tests for front-token - #11

supertokens · Nov 6, 2020 · 6e1852c · 6e1852c
1 parent f579c27
commit 6e1852c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 42 deletions.
diff --git a/test/axios.test.js b/test/axios.test.js
@@ -360,21 +360,15 @@ describe("Axios AuthHttpRequest class tests", function() {
                 });
                 assertEqual(userId, loginResponse.data);
 
-                try {
-                    // TODO: remove try catch
-                    let data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(Object.keys(data).length, 0);
-                } catch (ignored) {}
+                let data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(Object.keys(data).length, 0);
 
                 // update jwt data
                 let testResponse1 = await axios.post(`${BASE_URL}/update-jwt`, { key: "data" });
                 assertEqual(testResponse1.data.key, "data");
 
-                try {
-                    // TODO: remove try catch
-                    data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(data.key, "data");
-                } catch (ignored) {}
+                data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(data.key, "data");
 
                 // get jwt data
                 let testResponse2 = await axios.get(`${BASE_URL}/update-jwt`);
@@ -385,12 +379,9 @@ describe("Axios AuthHttpRequest class tests", function() {
                 assertEqual(testResponse3.data.key1, "data1");
                 assertEqual(testResponse3.data.key, undefined);
 
-                try {
-                    // TODO: remove try catch
-                    data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(data.key1, "data1");
-                    assertEqual(data.key, undefined);
-                } catch (ignored) {}
+                data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(data.key1, "data1");
+                assertEqual(data.key, undefined);
 
                 // get jwt data
                 let testResponse4 = await axios.get(`${BASE_URL}/update-jwt`);
@@ -541,11 +532,9 @@ describe("Axios AuthHttpRequest class tests", function() {
                 assertEqual(userId, loginResponse.data);
                 assertEqual(await supertokens.doesSessionExist(), true);
                 assertEqual(getAntiCSRFromCookie() !== null, true);
-                try {
-                    // TODO: remove this try catch after all drivers have implemented front-token
-                    let userIdFromToken = supertokens.getUserId();
-                    assertEqual(userIdFromToken, userId);
-                } catch (ignored) {}
+
+                let userIdFromToken = supertokens.getUserId();
+                assertEqual(userIdFromToken, userId);
 
                 // send api request to logout
                 let logoutResponse = await axios.post(`${BASE_URL}/logout`, JSON.stringify({ userId }), {

diff --git a/test/fetch.test.js b/test/fetch.test.js
@@ -348,11 +348,8 @@ describe("Fetch AuthHttpRequest class tests", function() {
 
                 assertEqual(await loginResponse.text(), userId);
 
-                try {
-                    // TODO: remove try catch
-                    let data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(Object.keys(data).length, 0);
-                } catch (ignored) {}
+                let data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(Object.keys(data).length, 0);
 
                 // update jwt data
                 let testResponse1 = await fetch(`${BASE_URL}/update-jwt`, {
@@ -366,11 +363,8 @@ describe("Fetch AuthHttpRequest class tests", function() {
                 let data1 = await testResponse1.json();
                 assertEqual(data1.key, "data");
 
-                try {
-                    // TODO: remove try catch
-                    data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(data.key, "data");
-                } catch (ignored) {}
+                data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(data.key, "data");
 
                 // get jwt data
                 let testResponse2 = await fetch(`${BASE_URL}/update-jwt`, { method: "get" });
@@ -390,12 +384,9 @@ describe("Fetch AuthHttpRequest class tests", function() {
                 assertEqual(data3.key1, "data1");
                 assertEqual(data3.key, undefined);
 
-                try {
-                    // TODO: remove try catch
-                    data = await supertokens.getJWTPayloadSecurely();
-                    assertEqual(data.key1, "data1");
-                    assertEqual(data.key, undefined);
-                } catch (ignored) {}
+                data = await supertokens.getJWTPayloadSecurely();
+                assertEqual(data.key1, "data1");
+                assertEqual(data.key, undefined);
 
                 // get jwt data
                 let testResponse4 = await fetch(`${BASE_URL}/update-jwt`, { method: "get" });
@@ -558,11 +549,9 @@ describe("Fetch AuthHttpRequest class tests", function() {
 
                 assertEqual(await supertokens.doesSessionExist(), true);
                 assertEqual(getAntiCSRFromCookie() !== null, true);
-                try {
-                    // TODO: remove this try catch after all drivers have implemented front-token
-                    let userIdFromToken = supertokens.getUserId();
-                    assertEqual(userIdFromToken, userId);
-                } catch (ignored) {}
+
+                let userIdFromToken = supertokens.getUserId();
+                assertEqual(userIdFromToken, userId);
 
                 // send api request to logout
                 let logoutResponse = await fetch(`${BASE_URL}/logout`, {