Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing tests regarding any type support in formFields #526

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

deepjyoti30-st
Copy link
Contributor

Summary of change

fixes issues with some tests that were failing after adding support for any type of field values in formFields

Failing tests

Test Plan

  • test_init_validation_emailpassword should pass
  • test_email_validation_checks_in_generate_token_API should pass

Screenshot 2024-09-24 at 8 31 10 PM

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

This commit fixes issues with some tests that were failing after adding
support for any type of field values in formFields
@rishabhpoddar rishabhpoddar merged commit fdb85d4 into 0.24 Sep 24, 2024
2 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/failing-tests-related-to-any-type-support branch September 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants