Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto transpiling to catchup to node sdk (as of 19.0 branch of node sdk) #517

Merged
merged 137 commits into from
Oct 25, 2024

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Jul 21, 2024

Summary of change

TODO

Related issues

TODO

Test Plan

TODO

Documentation changes

TODO

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core
  • Check that functions like list user by account info etc have been added to root async / syncio or not (basically check for any missing functions)
  • Check that st-t-dmns claim is not added by default in the session access token

Remaining TODOs for this PR

  • FIx issue with account linking returning erro code 007 instead of email already exists when signing up with email password if social login already exists.
  • Make use of AccountLinkingUser instead of User in all places in the SDK.
  • SessionContainer implementation needs to take recipe_id as an input arg as opposed to auto assigning it to user_id
  • In user_get api in dashboard:
    • Check implementation of get_search_params_from_url is correct
    • Remove mock of users oldest / newest get
  • Remove mock_get_user from dashboard/utils.py
  • Add the TOTP and MFA related checks in supertokens.init (thats commented out at the moment)
  • Make sure Literal is only imported from type_extension and not types
  • in account linking recipe, in verify_email_for_recipe_user_if_linked_accounts_are_verified, we need to pass attempt_account_linking=False when calling verify_email_using_token
  • Call to revoke_all_sessions_for_user in emailverification.recipe should uncomment the false
  • check everywhere for use of RecipeUserId(...) and make sure we are not just passing in user_id in it
  • change the auto linking part of sessions if an access token is present in the request

Recipes

  • accountlinking
  • mfa
  • dashboard
  • third party providers changes
  • emailpassword
  • emailverification
  • jwt
  • multitenancy
  • openid
  • passwordless
  • session
  • thirdparty
  • usermetadata
  • userroles
  • totp

@rishabhpoddar rishabhpoddar changed the base branch from 0.24 to 0.25 October 24, 2024 18:02
@rishabhpoddar rishabhpoddar marked this pull request as ready for review October 24, 2024 18:02
@rishabhpoddar rishabhpoddar merged commit 9a67aa1 into 0.25 Oct 25, 2024
15 of 43 checks passed
@rishabhpoddar rishabhpoddar deleted the auto-transpiling branch October 25, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant