feat: Use nest-asyncio when configured with env var #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KShivendu
commented
Sep 20, 2023
KShivendu
commented
Sep 20, 2023
rishabhpoddar
suggested changes
Sep 21, 2023
| try: | ||
| asyncio.get_event_loop() | ||
| except RuntimeError as ex: | ||
| import nest_asyncio as _ # type: ignore |
There was a problem hiding this comment.
why is this import here?
| except Exception: | ||
| return False | ||
|
|
||
|
|
There was a problem hiding this comment.
make sure that there is at least one thing in cicd where we run the python sdk (for example in e2e test with flask), where nest_asyncio is not a dependency and then we make sure it all works
10 tasks
rishabhpoddar
suggested changes
Sep 21, 2023
tests/test_config.py
Outdated
Comment on lines
807
to
827
| def test_nest_asyncio_import(): | ||
| from supertokens_python.async_to_sync_wrapper import nest_asyncio_enabled, sync | ||
| from os import getenv | ||
|
|
||
| circleci = getenv("CIRCLECI", "false") == "true" | ||
|
|
||
| if not circleci: | ||
| return | ||
|
|
||
| # Has to be circleci | ||
| if nest_asyncio_enabled(): | ||
| # nest-asyncio should be installed | ||
| sync(asyncio.sleep(0.1)) | ||
| else: | ||
| # nest-asyncio shouldn't be installed and sync() should throw error | ||
| try: | ||
| sync(asyncio.sleep(0.1)) | ||
| assert False, "Shouldn't come here" | ||
| except ModuleNotFoundError: | ||
| # should be missing | ||
| assert True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Use nest-asyncio when configured with env var
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the core