feat: Implement method to get plugin config properties #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sattvikc
requested changes
Feb 19, 2024
src/test/java/io/supertokens/storage/postgresql/test/PostgresSQLConfigTest.java
Show resolved
Hide resolved
src/main/java/io/supertokens/storage/postgresql/config/PostgreSQLConfig.java
Outdated
Show resolved
Hide resolved
sattvikc
approved these changes
Feb 23, 2024
sattvikc
requested changes
Feb 23, 2024
src/main/java/io/supertokens/storage/postgresql/config/PostgreSQLConfig.java
Outdated
Show resolved
Hide resolved
sattvikc
approved these changes
Feb 23, 2024
sattvikc
added a commit
that referenced
this pull request
May 24, 2024
* feat: Implement method to get plugin config properties (#186) * Add a new method to get the config as json * Update changelog * Remove the check for protected config from method * Revert version changes * Update descriptions * Update config properties descriptions to match those in the yaml files * Throw error when invalid fields * Refactor getConfigFieldsInfo method in Start and PostgreSQLConfig classes * fix: config info * fix: update config * fix: cleanup * fix: cleanup * fix: refactor config description * fix: type fix * fix: pr comments * fix: pr comments * fix: PR comments * fix: version and changelog * fix: remove unnecessary fields for dashboard * fix: refactor dashboard related * fix: impl --------- Co-authored-by: Sattvik Chakravarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Related issues
N/A
Test Plan
N/A
Documentation changes
N/A
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add them inimplementationDependencies.json.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR
N/A