feat: Add getInitialSessionAuthContext to compute SessionAuth context #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astounding-pegasus-21c111 canceled.
|
sasha240100
changed the title
✅ Deploy Preview for precious-marshmallow-968a81 canceled.
|
This was referenced Jan 24, 2024
Merged
porcellus
requested changes
Jan 25, 2024
Comment on lines
+119
to
+120
| isContextFromSSR: true; | ||
| loading: false; |
There was a problem hiding this comment.
These should not be required since they are static values.
There was a problem hiding this comment.
But they are expected by supertokens-auth-react, if they will be optional - that means we would have to polyfill them inside SessionAuth component, and in that case I would rather remove them completely from supertokens-node
sasha240100
changed the title
rishabhpoddar
suggested changes
Jan 26, 2024
| @@ -230,6 +230,24 @@ export default class NextJS { | |||
| return result; | |||
| } | |||
|
|
|||
| static async getInitialSessionAuthContext(session: SessionContainer | undefined): Promise<SSRSessionContextType> { | |||
There was a problem hiding this comment.
I don't think we need this function. And if we are going to keep it, why is it in the nextjs file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Adds
getInitialSessionAuthContextto support computing initialSessionAuthcontext (to be used withinitialSessionAuthContextproperty from supertokens/supertokens-auth-react#789)Related issues
Test Plan
Tested locally on a NextJS implementation using supertokens.
getInitialSessionAuthContext(session)creates an SSR session context that works like expected when passed intoinitialSessionAuthContext={}of<SessionAuth />component. Also covered by unit testsDocumentation changes
TODO.
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).Remaining TODOs for this PR