Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing tests related to checking invalid input in formFields #429

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented Sep 24, 2024

Summary of change

This commit fixes a failing test case that was testing for an invalid input in formFields with non string value but since that type of value is now supported, the test case was broken.

Failing test

Test Plan

TestInvalidAPIInputForFormFields should pass.

Screenshot 2024-09-24 at 7 45 08 PM

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

This commit fixes a failing test case that was testing for an invalid
input in formFields with non string value but since that type of value
is now supported, the test case was broken.
@rishabhpoddar rishabhpoddar merged commit ae70651 into 0.24 Sep 24, 2024
5 of 8 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/failing-tests-related-to-any-type-support branch September 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants