Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in jwks #425

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: memory leak in jwks #425

merged 1 commit into from
Sep 3, 2024

Conversation

sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Sep 3, 2024

Summary of change

Fixes memory leak in JWKS refresh.

Related issues

Test Plan

Added unit test

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Sep 3, 2024
@sattvikc sattvikc merged commit f2c10d0 into 0.24 Sep 3, 2024
12 of 17 checks passed
@sattvikc sattvikc deleted the memory-leak-fix branch September 3, 2024 07:03
cht368 pushed a commit to cht368/supertokens-golang that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant