Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie domain fix #409

Merged
merged 9 commits into from
May 8, 2024
Merged

Cookie domain fix #409

merged 9 commits into from
May 8, 2024

Conversation

rishabhpoddar
Copy link
Contributor

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@rishabhpoddar rishabhpoddar changed the base branch from 0.17 to 0.18 April 30, 2024 18:34
recipe/session/cookieAndHeaders.go Outdated Show resolved Hide resolved
recipe/session/sessionRequestFunctions.go Outdated Show resolved Hide resolved
recipe/session/session_test.go Show resolved Hide resolved
recipe/session/cookieAndHeaders.go Show resolved Hide resolved
recipe/session/cookieAndHeaders.go Show resolved Hide resolved
recipe/session/utils.go Show resolved Hide resolved
recipe/session/utils.go Show resolved Hide resolved
@rishabhpoddar rishabhpoddar changed the base branch from 0.18 to 0.19 May 8, 2024 11:49
@rishabhpoddar rishabhpoddar merged commit 2029c42 into 0.19 May 8, 2024
4 of 8 checks passed
@rishabhpoddar rishabhpoddar deleted the cookie-domain-fix branch May 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants