feat: Added network interceptor hook #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Nov 4, 2023
rishabhpoddar
suggested changes
Nov 6, 2023
|
|
||
| assert.Equal(t, 200, res.StatusCode) | ||
| assert.Equal(t, false, isNetworkIntercepted) | ||
| } |
There was a problem hiding this comment.
-
add a test where you modify the url of the request to the core, and then check that the function call to signIn returns an error with the right content (should have 404 status code, or the message should have a 404).
-
add a test where you modify the query params of the request to the core, and then check that the function to a GET request (like list roles for users), returns a 400 from the core
-
add a test where you modify the request body and then check that the function call to the core returns a 400
IamMayankThakur
changed the title
upgraded go version to go1.18
IamMayankThakur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Added network interceptor hook. This can be used to capture/modify all the requests sent to the core.
Related issues
Test Plan
Added unit test to test the flow.
Further unit tests may need to be added to test the flow when the request object is modified.
Documentation changes
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens/constants.gofrontendDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens/constants.go > version variablerecipe/thirdparty/providers/config_utils.gofile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.session/accessTokenVersions_test.goto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR