Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added debug flag in the SuperTokenConfig logging #385

Merged
merged 11 commits into from
Nov 1, 2023

Conversation

IamMayankThakur
Copy link
Contributor

@IamMayankThakur IamMayankThakur commented Nov 1, 2023

Summary of change

Added debug flag in the SuperTokenConfig in the init() for logging

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

Added unit tests

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

@IamMayankThakur IamMayankThakur force-pushed the feat/use-flag-for-logging branch from 18e2ee3 to 758edbc Compare November 1, 2023 06:37
@IamMayankThakur IamMayankThakur changed the base branch from master to 0.14 November 1, 2023 06:38
supertokens/models.go Outdated Show resolved Hide resolved
supertokens/supertokens.go Outdated Show resolved Hide resolved
supertokens/supertokens.go Outdated Show resolved Hide resolved
supertokens/supertokens.go Outdated Show resolved Hide resolved
recipe/session/logger_test.go Show resolved Hide resolved
recipe/session/logger_test.go Outdated Show resolved Hide resolved
recipe/session/logger_test.go Show resolved Hide resolved
recipe/session/logger_test.go Show resolved Hide resolved
recipe/session/testingUtils.go Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar changed the base branch from 0.14 to 0.16 November 1, 2023 13:52
supertokens/supertokens.go Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit 583b953 into 0.16 Nov 1, 2023
2 of 5 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/use-flag-for-logging branch November 1, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants