-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added debug
flag in the SuperTokenConfig logging
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamMayankThakur
force-pushed
the
feat/use-flag-for-logging
branch
from
November 1, 2023 06:37
18e2ee3
to
758edbc
Compare
rishabhpoddar
suggested changes
Nov 1, 2023
… the ENV variable
rishabhpoddar
suggested changes
Nov 1, 2023
rishabhpoddar
suggested changes
Nov 1, 2023
rishabhpoddar
suggested changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Added debug flag in the SuperTokenConfig in the init() for logging
Related issues
Test Plan
Added unit tests
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go
frontendDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go > version variable
recipe/thirdparty/providers/config_utils.go
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.session/accessTokenVersions_test.go
to account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR