Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Bump github.com/golang-jwt/jwt to v5 #367

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

constantoine
Copy link
Contributor

@constantoine constantoine commented Sep 20, 2023

Summary of change

  • Bumped github.com/golang-jtw/jwt version from v4 to v5.

  • Bumped github.com/MicahParks/keyfunc version from v1 to v2.

  • This PR is breaking because of a change in *keyfunc.JWKS.

Related issues

Test Plan

I ran the existing tests to ensure there was no regression.

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
  • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • [?] Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Left to do

  • Create new unreleased branch
  • Reflect about whether the breaking change is worth or not

@rishabhpoddar rishabhpoddar requested review from nkshah2 and sattvikc and removed request for nkshah2 September 20, 2023 13:02
@sattvikc sattvikc changed the base branch from master to 0.15 September 27, 2023 07:01
@rishabhpoddar rishabhpoddar changed the base branch from 0.15 to 0.16 September 27, 2023 07:10
@rishabhpoddar rishabhpoddar merged commit 96151ad into supertokens:0.16 Sep 27, 2023
2 of 5 checks passed
@rishabhpoddar
Copy link
Contributor

Thanks for this PR @constantoine. We have also added you to the core's repo readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants