feat: Add migration script for phone number normalisation #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anku255
commented
Nov 17, 2023
rishabhpoddar
suggested changes
Nov 17, 2023
rishabhpoddar
suggested changes
Nov 17, 2023
rishabhpoddar
suggested changes
Nov 20, 2023
rishabhpoddar
suggested changes
Nov 20, 2023
rishabhpoddar
suggested changes
Nov 20, 2023
rishabhpoddar
approved these changes
Nov 20, 2023
rishabhpoddar
merged commit 3ac2f20
into
feat/phone-number-normalisation-base
2 of 3 checks passed
rishabhpoddar
deleted the
feat/phone-number-normalisation-migration-script
branch
11 tasks
rishabhpoddar
pushed a commit
that referenced
this pull request
Nov 20, 2023
… Migration script (#885) * feat: Normalise phoneNumber received in the input before processing (#881) * feat: normalise phoneNumber received in the input before processing * feat: PR changes * feat: PR changes * feat: Improve test for invalid phone number inputs (#884) * feat: Add migration script for phone number normalisation (#882) * feat: Add migration script for phone number normalisation * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This pull request introduces phone number normalisation migration script that is supposed to be run on the all the core instances after migrating to version 7.0.12.
Related issues
Test Plan
I locally tested the script by creating
passwordless_users,passwordless_devices, andpasswordless_user_to_tenanttables, seeding them with unnormalized phone numbers, and confirming successful normalization after script execution. Tests covered both PostgreSQL and MySQL databases.Screenshots
Click here to see the script output logs when run with 20K rows in each table.
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any core config (similar to theaccess_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deleting the user as well ifdeleteUserIdMappingToois false.