fix: pr comments

supertokens · Nov 3, 2023 · fc45766 · fc45766
1 parent 0beb42c
commit fc45766
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/io/supertokens/webserver/RequestStats.java b/src/main/java/io/supertokens/webserver/RequestStats.java
@@ -97,6 +97,8 @@ public static RequestStats getInstance(Main main, AppIdentifier appIdentifier) t
             return (RequestStats) main.getResourceDistributor()
                     .getResource(appIdentifier.getAsPublicTenantIdentifier(), RESOURCE_KEY);
         } catch (TenantOrAppNotFoundException e) {
+            // appIdentifier parameter is coming from the API request and hence we need to check if the app exists
+            // before creating a resource for it
             if (Multitenancy.getTenantInfo(main, appIdentifier.getAsPublicTenantIdentifier()) == null) {
                 throw e;
             }

diff --git a/src/main/java/io/supertokens/webserver/WebserverAPI.java b/src/main/java/io/supertokens/webserver/WebserverAPI.java
@@ -484,7 +484,7 @@ protected void service(HttpServletRequest req, HttpServletResponse resp) throws
         try {
             RequestStats.getInstance(main, tenantIdentifier.toAppIdentifier()).updateRequestStats();
         } catch (TenantOrAppNotFoundException e) {
-            throw new IllegalStateException(e); // should never happen
+            // Ignore the error as we would have already sent the response for tenantNotFound
         }
     }
 

diff --git a/src/test/java/io/supertokens/test/RequestStatsTest.java b/src/test/java/io/supertokens/test/RequestStatsTest.java
@@ -278,8 +278,8 @@ public void testWithNonExistantApp() throws Exception {
                             1000, null, Utils.getCdiVersionStringLatestForTests(), null);
             fail();
         } catch (HttpResponseException e) {
-            assertEquals(500, e.statusCode);
-            assertEquals("Http error. Status Code: 500. Message: AppId or tenantId not found => Tenant with the following connectionURIDomain, appId and tenantId combination not found: (, a1, public)", e.getMessage());
+            assertEquals(400, e.statusCode);
+            assertEquals("Http error. Status Code: 400. Message: AppId or tenantId not found => Tenant with the following connectionURIDomain, appId and tenantId combination not found: (, a1, public)", e.getMessage());
         }
 
         process.kill();