fix: review fixes

supertokens · Oct 1, 2024 · 807f617 · 807f617
1 parent 72706f9
commit 807f617
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/config.yaml b/config.yaml
@@ -152,6 +152,7 @@ core_config_version: 0
 # if there are more CUDs in the database and block all other CUDs from being used from this instance.
 # supertokens_saas_load_only_cud:
 
-# (DIFFERENT_ACROSS_TENANTS | OPTIONAL | Default: 1) int value. If specified, the supertokens core will use the
-# specified number of threads to complete the migration of users.
+# (DIFFERENT_ACROSS_TENANTS | OPTIONAL | Default: number of available processor cores) int value. If specified,
+# the supertokens core will use the specified number of threads to complete the migration of users.
 # bulk_migration_parallelism:
+
diff --git a/devConfig.yaml b/devConfig.yaml
@@ -152,6 +152,6 @@ disable_telemetry: true
 # if there are more CUDs in the database and block all other CUDs from being used from this instance.
 # supertokens_saas_load_only_cud:
 
-# (DIFFERENT_ACROSS_TENANTS | OPTIONAL | Default: 1) int value. If specified, the supertokens core will use the
-# specified number of threads to complete the migration of users.
+# (DIFFERENT_ACROSS_TENANTS | OPTIONAL | Default: number of available processor cores) int value. If specified,
+# the supertokens core will use the specified number of threads to complete the migration of users.
 # bulk_migration_parallelism:
diff --git a/src/main/java/io/supertokens/bulkimport/BulkImportUserUtils.java b/src/main/java/io/supertokens/bulkimport/BulkImportUserUtils.java
@@ -264,8 +264,8 @@ private String validateAndNormaliseExternalUserId(String externalUserId, List<St
             return null;
         }
 
-        if (externalUserId.length() > 255) {
-            errors.add("externalUserId " + externalUserId + " is too long. Max length is 255.");
+        if (externalUserId.length() > 128) {
+            errors.add("externalUserId " + externalUserId + " is too long. Max length is 128.");
         }
 
         if (!allExternalUserIds.add(externalUserId)) {

diff --git a/src/main/java/io/supertokens/config/CoreConfig.java b/src/main/java/io/supertokens/config/CoreConfig.java
@@ -307,7 +307,9 @@ public class CoreConfig {
 
     @NotConflictingInApp
     @JsonProperty
-    private int bulk_migration_parallelism = 1;
+    @ConfigDescription("If specified, the supertokens core will use the specified number of threads to complete the " +
+            "migration of users. (Default: number of available processor cores).")
+    private int bulk_migration_parallelism =  Runtime.getRuntime().availableProcessors();
 
     public static Set<String> getValidFields() {
         CoreConfig coreConfig = new CoreConfig();