-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add e2e test for OAuth2 #843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
porcellus
requested changes
Aug 1, 2024
porcellus
added a commit
that referenced
this pull request
Oct 3, 2024
* feat: add boilerplate for OAuth2 recipe * feat!: add initial impl for OAuth2 (#833) * feat: add initial impl of OAuth2 recipe * build: add missing bundle conf * fix: wrong recipe id * feat: clean up todos * feat: make use of getLoginChallengeInfo * fix: self-review fixes * refactor: rename OAuth2 to OAuth2Provider * feat: show logo for oauth clients * fix: Rename oauth2 to oauth2provider * test: Add e2e test for OAuth2 (#843) * test: Add e2e test for OAuth2 * fix: PR changes * feat: add tryLinkingWithSessionUser, forceFreshAuth and small test fixes * test: add explanation comment to oauth2 tests --------- Co-authored-by: Mihaly Lengyel <[email protected]> * feat: add a route we can use to force refreshes * test: extend/stabilize tests * feat: Add functions and prebuiltUI for oauth2 logout (#850) * feat: Add functions and prebuiltUI for oauth2 logout * Update lib/ts/recipe/oauth2provider/components/themes/themeBase.tsx Co-authored-by: Mihály Lengyel <[email protected]> * fix: PR changes * fix: PR changes --------- Co-authored-by: Mihály Lengyel <[email protected]> * Add OAuth2 example apps (#854) * feat: Add st-oauth2-authorization-server example * feat: Add with-oauth2-without-supertokens * feat: Add with-oauth2-with-supertokens example * feat: keep the tenantId queryparam during redirections * feat: update to match node changes * test: stability fixes * test: update dep version and fix tests * fix: ignore appname in the oauth flow if it is empty * fix: fix typo * feat: handle not initialized OAuth2Provider recipe more gracefully * feat: ignore loginChallenge queryparam on auth page if we couldn't load it * feat: show an error if the getLoginChallengeInfo errors out * feat: update prebuiltui types and add test into with-typescript * test: add more debugging options for ci * fix: shouldTryLinkingWithSessionUser * chore: update versions * ci: do not forward browser logs into the console on CI * test: improve request logging in tests * test: update test expectations to match new node logic * chore: update web-js dep version in lock --------- Co-authored-by: Mihaly Lengyel <[email protected]> * refactor: self-review fixes * refactor: self-review fixes * docs: remove oauth2 examples until the restructuring is done * chore: expand changelog * chore: set web-js version to new version branch * chore: update size limits --------- Co-authored-by: Ankit Tiwari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds a e2e test for OAuth2 using a generic react OAuth2 library.
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.someFunc: function () {..}
).size-limit
section ofpackage.json
with the size limit set to the current size rounded up.rollup.config.mjs
lib/ts/types.ts
lib/ts/recipe/multifactorauth/types.ts
Remaining TODOs for this PR