Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e with 0.41 #836

Merged
merged 3 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

## [0.41.2] - UNRELEASED
## [0.41.3] - 2024-07-16

- Fixes e2e test

## [0.41.2]

### Test changes

Expand Down
6 changes: 0 additions & 6 deletions addDevTag
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# check if we need to merge master into this branch------------
if [[ $(git log origin/master ^HEAD) ]]; then
echo "You need to merge master into this branch. Exiting"
exit 1
fi

# get version------------
version=`cat package.json | grep -e '"version":'`

Expand Down
2 changes: 1 addition & 1 deletion lib/build/genericComponentOverrideContext.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/build/version.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/ts/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
* License for the specific language governing permissions and limitations
* under the License.
*/
export const package_version = "0.41.2";
export const package_version = "0.41.3";
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "supertokens-auth-react",
"version": "0.41.2",
"version": "0.41.3",
"description": "ReactJS SDK that provides login functionality with SuperTokens.",
"main": "./index.js",
"engines": {
Expand Down
16 changes: 12 additions & 4 deletions test/end-to-end/accountlinking.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,18 @@ describe("SuperTokens Account linking", function () {
await tryThirdPartySignInUp(page, email, false, email2);

assert.strictEqual(new URL(page.url()).pathname, "/auth/");
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)"
);
const features = await getFeatureFlags();
if (features.includes("accountlinking-fixes")) {
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_004)"
);
} else {
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)"
);
}
});

it("should not allow sign in w/ an unverified thirdparty user in case of conflict", async function () {
Expand Down
Loading