Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip unnecessary updates in SessionAuth #831

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

skip unnecessary updates in SessionAuth

Related issues

Test Plan

Added an extra test that replacates a case we've seen on a user call: running signout on context updates that have doesSessionExist === false. This used to trigger an infinite re-render loop.

Documentation changes

None, this is a small optimization that people should not rely on.

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Copy link

github-actions bot commented Jun 23, 2024

size-limit report 📦

Path Size
lib/build/index.js 22.48 KB (+0.22% 🔺)
recipe/session/index.js 23.23 KB (+0.18% 🔺)
recipe/session/prebuiltui.js 27.77 KB (+0.14% 🔺)
recipe/thirdparty/index.js 27.76 KB (0%)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (0%)
recipe/passwordless/index.js 14.76 KB (0%)
recipe/emailverification/prebuiltui.js 32.46 KB (+0.16% 🔺)
recipe/thirdparty/prebuiltui.js 47.67 KB (+0.07% 🔺)
recipe/emailpassword/prebuiltui.js 38.54 KB (+0.14% 🔺)
recipe/passwordless/prebuiltui.js 125.88 KB (+0.04% 🔺)
recipe/multitenancy/index.js 6.67 KB (0%)
recipe/multifactorauth/index.js 10.77 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.31 KB (+0.14% 🔺)

@porcellus porcellus merged commit f61f860 into 0.42 Jun 23, 2024
25 of 27 checks passed
@porcellus porcellus deleted the feat/skip_unnecessary_updates_in_sessionauth branch June 23, 2024 22:45
ohansFavour pushed a commit that referenced this pull request Jun 25, 2024
* feat: skip unnecessary updates in SessionAuth

* chore: update version

* chore: update size limit
ohansFavour pushed a commit that referenced this pull request Jun 25, 2024
* feat: skip unnecessary updates in SessionAuth

* chore: update version

* chore: update size limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant