-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor UX improvements #811
Merged
rishabhpoddar
merged 15 commits into
0.40
from
fix/show_access_denied_on_no_next_factor
Apr 15, 2024
Merged
fix: minor UX improvements #811
rishabhpoddar
merged 15 commits into
0.40
from
fix/show_access_denied_on_no_next_factor
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
size-limit report 📦
|
porcellus
changed the title
fix: debugging/DX improvements
fix: debugging/DX/(minor)UX improvements
Apr 11, 2024
porcellus
changed the title
fix: debugging/DX/(minor)UX improvements
fix: minor UX improvements
Apr 11, 2024
… the current page
rishabhpoddar
suggested changes
Apr 13, 2024
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "supertokens-auth-react", | |||
"version": "0.39.1", | |||
"version": "0.39.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider making this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with making this a breaking change.
rishabhpoddar
approved these changes
Apr 15, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
clearOnSubmit
now only clears the field value if the request returned an error. This is because the form navigates on success, making clearing the field unnecessary (which can lead to confusing UX if the navigation takes too long).SessionAuth
contents popped in before navigating away if a claim validator failed. NowSessionAuth
does not set the context before navigation.name
property optional in custom provider configsRelated issues
Test Plan
Updated tests cases should cover this.
Manually tested:
Documentation changes
N/A
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.someFunc: function () {..}
).size-limit
section ofpackage.json
with the size limit set to the current size rounded up.rollup.config.mjs
lib/ts/types.ts
lib/ts/recipe/multifactorauth/types.ts