feat: Update userContext type and add isNewPrimaryUser in GetRedirectionURLContext #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
anku255
changed the title
15 tasks
rishabhpoddar
suggested changes
Dec 7, 2023
lib/ts/recipe/emailpassword/components/features/signInAndUp/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/emailverification/components/features/emailVerification/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/emailverification/components/features/emailVerification/index.tsx
Outdated
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Dec 7, 2023
lib/ts/recipe/thirdpartyemailpassword/components/themes/signInAndUp/index.tsx
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Dec 8, 2023
rishabhpoddar
merged commit 9379e48
into
feat/get-redirection-url-allow-null
20 of 23 checks passed
rishabhpoddar
added a commit
that referenced
this pull request
Dec 11, 2023
* feat: Allow returning null from getRedirectionURL override * feat: Update version and include e2e tests * Update CHANGELOG.md Co-authored-by: Rishabh Poddar <[email protected]> * Remove success screen in passwordless login * Fix examples * Update version and Changelog * Update version * Delete watchmanconfig * Update CHANGELOG.md * Update CHANGELOG.md * Update changelog * Redirect only if url changes * PR changes * Update history type, userContext in getRedirectURL * Rename history to navigate * Update changelog * Update lib/ts/recipe/recipeModule/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/recipeModule/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * PR changes * Update changelog * feat: Update userContext type and add isNewPrimaryUser in GetRedirectionURLContext (#772) * Update userContext type and make it required in internal functions * Add isNewPrimaryUser in GetRedirectionURLContext * PR changes --------- Co-authored-by: Rishabh Poddar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR -
userContextfromanytoRecord<string, unknown>userContextrequired in internal functions wherever possiblegetNormalisedUserContextto populateuserContextwherever it was not available/passedisNewPrimaryUserboolean in GetRedirectionURLContextChecklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjs