Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update passwordless to support OTP based MFA #759

Merged
merged 47 commits into from
Dec 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
26d1e48
chore: update to mfa branch of web-js
porcellus Oct 12, 2023
db3be18
feat: mfa recipe setup
porcellus Oct 13, 2023
8b339a4
feat: add support for firstFactor
porcellus Oct 13, 2023
02429f8
fix: fix chooseComponentBasedOnFirstFactors to properly get the max c…
porcellus Oct 15, 2023
f3c955e
feat: navigation based on claim validation failures
porcellus Oct 16, 2023
8932a0e
feat: implement factor chooser screen
porcellus Oct 16, 2023
ad99b5f
feat: factor chooser fixes and updates
porcellus Oct 19, 2023
083e908
feat: update pwless to support otp based mfa
porcellus Oct 19, 2023
e61dd45
feat: add back button to factor chooser and filter the options
porcellus Oct 30, 2023
1114c60
Merge remote-tracking branch 'origin/feat/mfa/recipe-setup' into feat…
porcellus Oct 30, 2023
b589515
feat: update how back buttons are styled
porcellus Oct 30, 2023
85b1c4d
test: update how back button is selected in tests
porcellus Oct 30, 2023
4b1bd32
Merge remote-tracking branch 'origin/feat/mfa/recipe-setup' into feat…
porcellus Oct 30, 2023
a9ce3b5
feat: self-review fixes & updates
porcellus Oct 31, 2023
c62fd92
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Oct 31, 2023
fa3d6d5
feat: self-review fixes&cleanup
porcellus Oct 31, 2023
3deb3cd
fix: firstFactors + test helpers
porcellus Nov 6, 2023
9653c1b
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 6, 2023
6b84340
fix: small test based fixes
porcellus Nov 6, 2023
7355f50
feat: clean up first factor handling
porcellus Nov 7, 2023
e66c584
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 7, 2023
fb89c18
refactor: rename passwordlessFirstFactors since it's not only first f…
porcellus Nov 9, 2023
792316b
feat: self-review fixes
porcellus Nov 9, 2023
f45271c
chore: add mfa ui to size limits
porcellus Nov 9, 2023
1990358
refactor: remove updates that will be added in other PRs + simplifica…
porcellus Nov 9, 2023
666d3fb
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 9, 2023
46ae327
chore: increase size limits
porcellus Nov 9, 2023
150c9ad
test: add reset method to mfa recipe
porcellus Nov 9, 2023
b1203cf
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 9, 2023
907930e
feat: make sure firstFactor conflicts hit user error boundaries
porcellus Nov 13, 2023
f84d9b8
feat: update design and fix font-weight issues
porcellus Nov 15, 2023
ea768d1
chore: update web-js dep
porcellus Nov 15, 2023
a9b010f
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 15, 2023
598be73
feat: update design
porcellus Nov 15, 2023
a4c0095
refactor: self-review fixes
porcellus Nov 16, 2023
b397c67
refactor: self-review fixes
porcellus Nov 16, 2023
69a2110
chore: update changelog
porcellus Nov 16, 2023
abce472
feat: use redirect info if available on mfa success
porcellus Nov 16, 2023
00ee185
refactor: use redirectToFactor instead of re-implementing
porcellus Nov 16, 2023
7d8f419
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 16, 2023
21dee6b
fix: add missing param into redirectToFactorChooser call
porcellus Nov 16, 2023
7891b73
fix: override and routing fixes
porcellus Nov 21, 2023
da4ac03
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Nov 21, 2023
9d8fae1
feat: allow showing matching sub-recipe components if not on websiteb…
porcellus Dec 6, 2023
c0d686f
Merge branch 'feat/mfa/recipe-setup' into feat/mfa/otp
porcellus Dec 6, 2023
fb74a61
Merge remote-tracking branch 'origin/feat/mfa/base' into feat/mfa/otp
porcellus Dec 10, 2023
ec913fb
fix: exposing mfa in tppwless + cleanup/refactor
porcellus Dec 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,25 @@ To use this you'll need compatible versions:
- Refactored/renamed some styling options (`resetPasswordHeaderTitle` -> `headerTitle withBackButton`)
- Added a `useShadowDom` prop to the `AccessDeniedScreen`
- Added an `error` prop to the `AccessDeniedScreen` that can be used to describe the reason access is denied.
- Added new MFA related components to Passwordless
- Added new prop `mfaFeature` to recipe config
- `disableDefaultUI`: can be used to disable paths: `${websiteBasePath}/mfa/otp-phone`, `${websiteBasePath}/mfa/otp-email`
- `style`: is applied on top of normal sign in/up styles on the MFA paths
- New embeddable components:
- `MfaOtpPhone` (by default handling path `${websiteBasePath}/mfa/otp-phone`)
- `MfaOtpEmail` (by default handling path `${websiteBasePath}/mfa/otp-email`)
- New overrideable components:
- `PasswordlessMFAHeader_Override`
- `PasswordlessMFAFooter_Override`
- `PasswordlessMFAOTPHeader_Override`
- `PasswordlessMFAOTPFooter_Override`
- Please note, that during MFA we re-use the existing overrideable comps for the form section:
- `PasswordlessEmailForm_Override`
- `PasswordlessPhoneForm_Override`
- `PasswordlessEmailOrPhoneForm_Override`
- Removed an `ErrorBoundary` wrapping all our feature components to make sure all errors are properly catchable by the app
- Added a `footer` prop to `EmailOrPhoneForm`, `EmailForm` and `PhoneForm` which is used to override the default sign in/up footers in case the component is for MFA
- The passwordless and thirdpartypasswordless sign in/up screens now respect the first configuration (defined in the `MultiFactorAuth` recipe or in the tenant information) when selecting the available contact methods.
- Fixed a font loading issue, that caused apps using the default (Rubik) font to appear with the incorrect font weights
- Some default styling has changed related to how fonts/font-weights are applied

Expand Down
8 changes: 8 additions & 0 deletions examples/for-tests-react-16/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,10 @@ function getThirdPartyPasswordlessConfigs({ staticProviderList, disableDefaultUI
disableDefaultUI,
style: theme.style,
},
mfaFeature: {
disableDefaultUI,
style: theme,
},
});
}

Expand Down Expand Up @@ -845,6 +849,10 @@ function getPasswordlessConfigs({ disableDefaultUI }) {
disableDefaultUI,
style: theme.style,
},
mfaFeature: {
disableDefaultUI,
style: theme,
},
});
}

Expand Down
8 changes: 8 additions & 0 deletions examples/for-tests/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,10 @@ function getThirdPartyPasswordlessConfigs({ staticProviderList, disableDefaultUI
disableDefaultUI,
style: theme,
},
mfaFeature: {
disableDefaultUI,
style: theme,
},
});
}

Expand Down Expand Up @@ -1078,6 +1082,10 @@ function getPasswordlessConfigs({ disableDefaultUI }) {
disableDefaultUI,
style: theme,
},
mfaFeature: {
disableDefaultUI,
style: theme,
},
});
}

Expand Down
2 changes: 2 additions & 0 deletions lib/build/components/assets/otpEmailIcon.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions lib/build/components/assets/otpSMSIcon.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions lib/build/components/errorBoundary.d.ts

This file was deleted.

2 changes: 1 addition & 1 deletion lib/build/emailverification-shared2.js

Large diffs are not rendered by default.

91 changes: 31 additions & 60 deletions lib/build/index2.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/build/multifactorauthprebuiltui.js

Large diffs are not rendered by default.

146 changes: 146 additions & 0 deletions lib/build/passwordless-shared2.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2,874 changes: 1,995 additions & 879 deletions lib/build/passwordless-shared3.js

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions lib/build/passwordless.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions lib/build/passwordlessprebuiltui.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading