Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: twitter provider #743

Merged
merged 8 commits into from
Sep 27, 2023
Merged

feat: twitter provider #743

merged 8 commits into from
Sep 27, 2023

Conversation

Chakravarthy7102
Copy link
Contributor

@Chakravarthy7102 Chakravarthy7102 commented Sep 26, 2023

Summary of change

Adds new Twitter Provider

Mobile View

Screenshot from 2023-09-27 14-53-45

Tablet View

Screenshot from 2023-09-27 14-54-06

Laptop or more wider screens.

Screenshot from 2023-09-27 14-54-26

And with Legacy twitter logo.
Screenshot from 2023-09-27 14-58-18

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

@Chakravarthy7102 Chakravarthy7102 changed the base branch from master to 0.35 September 26, 2023 11:36
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

size-limit report 📦

Path Size
lib/build/index.js 14.18 KB (0%)
recipe/session/index.js 15.14 KB (0%)
recipe/session/prebuiltui.js 17.76 KB (0%)
recipe/thirdpartyemailpassword/index.js 29.66 KB (+0.86% 🔺)
recipe/thirdparty/index.js 26.44 KB (+0.93% 🔺)
recipe/emailpassword/index.js 9.94 KB (0%)
recipe/emailverification/index.js 7.26 KB (0%)
recipe/passwordless/index.js 63.47 KB (0%)
recipe/thirdpartypasswordless/index.js 84.21 KB (+0.31% 🔺)
recipe/emailverification/prebuiltui.js 22.45 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 53.8 KB (+0.43% 🔺)
recipe/thirdparty/prebuiltui.js 38.51 KB (+0.66% 🔺)
recipe/emailpassword/prebuiltui.js 27.51 KB (0%)
recipe/passwordless/prebuiltui.js 102.75 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.38 KB (+0.19% 🔺)
recipe/multitenancy/index.js 6.12 KB (0%)

@Chakravarthy7102 Chakravarthy7102 marked this pull request as draft September 26, 2023 12:06
@Chakravarthy7102 Chakravarthy7102 marked this pull request as ready for review September 26, 2023 13:35
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add screenshots with this provider enabled using the new and the legacy logos + how it shows in responsive mode (mobile, tablet etc)

lib/ts/recipe/thirdparty/providers/twitter.tsx Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit fbad845 into 0.35 Sep 27, 2023
19 of 22 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/twitter-provider branch September 27, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants