test: fix ci failures by making tests more stable (#821)

supertokens · May 24, 2024 · d4b792d · d4b792d
1 parent 440512b
commit d4b792d
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/end-to-end/signin-rrdv5.test.js b/test/end-to-end/signin-rrdv5.test.js
@@ -572,6 +572,7 @@ describe("SuperTokens SignIn with react router dom v5", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/redirect-to-this-custom-path");
                 assert.deepStrictEqual(consoleLogs, [
@@ -611,6 +612,7 @@ describe("SuperTokens SignIn with react router dom v5", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/CasE/Case-SensItive1-PAth");
                 assert.deepStrictEqual(consoleLogs, [

diff --git a/test/end-to-end/signin-rrdv6.test.js b/test/end-to-end/signin-rrdv6.test.js
@@ -720,6 +720,7 @@ describe("SuperTokens SignIn with react router dom v6", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/redirect-to-this-custom-path");
                 assert.deepStrictEqual(consoleLogs, [
@@ -760,6 +761,7 @@ describe("SuperTokens SignIn with react router dom v6", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/CasE/Case-SensItive1-PAth");
                 assert.deepStrictEqual(consoleLogs, [

diff --git a/test/end-to-end/signin.test.js b/test/end-to-end/signin.test.js
@@ -102,6 +102,7 @@ describe("SuperTokens SignIn", function () {
         page = await browser.newPage();
         page.on("console", (consoleObj) => {
             const log = consoleObj.text();
+            // console.log(log);
             if (log.startsWith("ST_LOGS")) {
                 consoleLogs.push(log);
             }
@@ -660,6 +661,7 @@ describe("SuperTokens SignIn", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/redirect-to-this-custom-path");
                 assert.deepStrictEqual(consoleLogs, [
@@ -700,6 +702,7 @@ describe("SuperTokens SignIn", function () {
                     submitFormReturnRequestAndResponse(page, SIGN_IN_API),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
+                await page.waitForSelector(".sessionInfo-user-id");
                 const pathname = await page.evaluate(() => window.location.pathname);
                 assert.deepStrictEqual(pathname, "/CasE/Case-SensItive1-PAth");
                 assert.deepStrictEqual(consoleLogs, [

diff --git a/test/end-to-end/thirdparty.test.js b/test/end-to-end/thirdparty.test.js
@@ -109,6 +109,7 @@ export function getThirdPartyTestCases({ authRecipe, rid, signInUpPageLoadLogs,
                 loginWithAuth0(page),
                 page.waitForResponse((response) => response.url() === SIGN_IN_UP_API && response.status() === 200),
             ]);
+            await page.waitForSelector(".sessionInfo-user-id");
             const pathname = await page.evaluate(() => window.location.pathname);
             assert.deepStrictEqual(pathname, "/dashboard");
             assert.deepStrictEqual(consoleLogs, [
@@ -213,6 +214,7 @@ export function getThirdPartyTestCases({ authRecipe, rid, signInUpPageLoadLogs,
                 loginWithAuth0(page),
                 page.waitForResponse((response) => response.url() === SIGN_IN_UP_API && response.status() === 200),
             ]);
+            await page.waitForSelector(".sessionInfo-user-id");
             const pathname = await page.evaluate(() => window.location.pathname);
             assert.deepStrictEqual(pathname, "/dashboard");
             assert.deepStrictEqual(consoleLogs, [

diff --git a/test/end-to-end/thirdpartyemailpassword.test.js b/test/end-to-end/thirdpartyemailpassword.test.js
@@ -293,6 +293,7 @@ describe("SuperTokens Third Party Email Password", function () {
                 loginWithAuth0(page),
                 page.waitForResponse((response) => response.url() === SIGN_IN_UP_API && response.status() === 200),
             ]);
+            await page.waitForSelector(".sessionInfo-user-id");
             const pathname = await page.evaluate(() => window.location.pathname);
             assert.deepStrictEqual(pathname, "/dashboard");
             assert.deepStrictEqual(consoleLogs, [