Skip to content

Commit

Permalink
implements fixes (#835)
Browse files Browse the repository at this point in the history
  • Loading branch information
rishabhpoddar authored Jul 15, 2024
1 parent 2f636f3 commit b7d68c9
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 10 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

## [0.43.1] - 2024-07-15

- Fixes to e2e test

## [0.43.0] - 2024-06-25

### Changes
Expand Down
2 changes: 1 addition & 1 deletion lib/build/genericComponentOverrideContext.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/build/version.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/ts/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
* License for the specific language governing permissions and limitations
* under the License.
*/
export const package_version = "0.43.0";
export const package_version = "0.43.1";
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "supertokens-auth-react",
"version": "0.43.0",
"version": "0.43.1",
"description": "ReactJS SDK that provides login functionality with SuperTokens.",
"main": "./index.js",
"engines": {
Expand Down
16 changes: 12 additions & 4 deletions test/end-to-end/accountlinking.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,18 @@ describe("SuperTokens Account linking", function () {
await tryThirdPartySignInUp(page, email, false, email2);

assert.strictEqual(new URL(page.url()).pathname, "/auth/");
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)"
);
const features = await getFeatureFlags();
if (features.includes("accountlinking-fixes")) {
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_004)"
);
} else {
assert.strictEqual(
await getGeneralError(page),
"Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)"
);
}
});

it("should not allow sign in w/ an unverified thirdparty user in case of conflict", async function () {
Expand Down

0 comments on commit b7d68c9

Please sign in to comment.