fix: properly apply getSecondaryFactorInfo from user config

supertokens · Nov 7, 2024 · 34647fb · 34647fb
1 parent bfe9f61
commit 34647fb
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 12 deletions.
diff --git a/lib/build/multifactorauth-shared2.js b/lib/build/multifactorauth-shared2.js
diff --git a/lib/build/multifactorauthprebuiltui.js b/lib/build/multifactorauthprebuiltui.js
diff --git a/lib/build/recipe/multifactorauth/components/themes/factorChooser/factorOption.d.ts b/lib/build/recipe/multifactorauth/components/themes/factorChooser/factorOption.d.ts
diff --git a/lib/build/recipe/multifactorauth/types.d.ts b/lib/build/recipe/multifactorauth/types.d.ts
diff --git a/lib/ts/recipe/multifactorauth/components/themes/factorChooser/factorOption.tsx b/lib/ts/recipe/multifactorauth/components/themes/factorChooser/factorOption.tsx
@@ -32,12 +32,12 @@ export const FactorOption = withOverride(
         id: string;
         name: string;
         description: string;
-        logo: FC;
+        logo: FC | undefined;
     }): JSX.Element {
         const t = useTranslation();
         return (
             <a data-supertokens={`factorChooserOption ${id}`} onClick={onClick}>
-                <div data-supertokens="factorLogo"> {logo({})}</div>
+                <div data-supertokens="factorLogo"> {logo ? logo({}) : null}</div>
                 <div data-supertokens="factorOptionText">
                     <h6 data-supertokens="factorName">{t(name)}</h6>
                     <p data-supertokens="factorDescription">{t(description)}</p>

diff --git a/lib/ts/recipe/multifactorauth/types.ts b/lib/ts/recipe/multifactorauth/types.ts
@@ -124,7 +124,7 @@ export type SecondaryFactorRedirectionInfo = {
     id: string;
     name: string;
     description: string;
-    logo: FC;
+    logo: FC | undefined;
     path: string;
 };
 

diff --git a/lib/ts/recipe/multifactorauth/utils.ts b/lib/ts/recipe/multifactorauth/utils.ts
@@ -37,7 +37,7 @@ export function normaliseMultiFactorAuthFeature(config?: Config): NormalisedConf
         ...normaliseRecipeModuleConfig(config),
         disableDefaultUI,
         firstFactors: config?.firstFactors,
-        getSecondaryFactorInfo: (orig) => orig,
+        getSecondaryFactorInfo: config?.getSecondaryFactorInfo ?? ((orig) => orig),
         factorChooserScreen: config.factorChooserScreen ?? {},
         override,
     };