instead of form submit apply type test within onChange function itself

supertokens · Oct 26, 2023 · 2480ebd · 2480ebd
1 parent 2be7cfa
commit 2480ebd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 44 deletions.
diff --git a/lib/build/emailpassword-shared7.js b/lib/build/emailpassword-shared7.js
diff --git a/lib/ts/recipe/emailpassword/components/library/formBase.tsx b/lib/ts/recipe/emailpassword/components/library/formBase.tsx
@@ -120,6 +120,14 @@ export const FormBase: React.FC<FormBaseProps<any>> = (props) => {
 
     const onInputChange = useCallback(
         (field: APIFormField) => {
+            try {
+                if (typeof field.value !== "string") {
+                    throw new Error(`${field.id} value must be a string`);
+                }
+            } catch (error) {
+                console.error(error);
+                return props.onError("SOMETHING_WENT_WRONG_ERROR");
+            }
             updateFieldState(field.id, (os) => ({ ...os, value: field.value, error: undefined }));
             props.clearError();
         },
@@ -145,19 +153,6 @@ export const FormBase: React.FC<FormBaseProps<any>> = (props) => {
                 };
             });
 
-            // field.value must be a string
-            try {
-                const fieldsWithIncorrectValues = apiFields.filter((field) => typeof field.value !== "string");
-                if (fieldsWithIncorrectValues.length > 0) {
-                    const errorFields = fieldsWithIncorrectValues.map(({ id }) => id).join(", ");
-                    throw new Error(`${errorFields} value must be a string`);
-                }
-            } catch (error) {
-                console.error(error);
-                setIsLoading(false);
-                return props.onError("SOMETHING_WENT_WRONG_ERROR");
-            }
-
             const fieldUpdates: FieldState[] = [];
             // Call API.
             try {