refactor: remove updates that will be added in other PRs + simplifica…

…tions
supertokens · Nov 9, 2023 · 1990358 · 1990358
1 parent f45271c
commit 1990358
Show file tree

Hide file tree

Showing 15 changed files with 23 additions and 593 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 #### Introducing MFA
 
-With this release, we are introducing MultiFactorAuthentication and TOTP, this will let you:
+With this release, we are introducing MultiFactorAuth and TOTP, this will let you:
 
 -   require (2FA or MFA) during sign in
 -   make use of our TOTP

diff --git a/lib/build/components/assets/otpIcon.d.ts b/lib/build/components/assets/otpIcon.d.ts
diff --git a/lib/build/multifactorauth-shared.js b/lib/build/multifactorauth-shared.js
diff --git a/lib/build/passwordless-shared2.js b/lib/build/passwordless-shared2.js
diff --git a/lib/build/passwordless.js b/lib/build/passwordless.js
diff --git a/lib/build/recipe/multifactorauth/index.d.ts b/lib/build/recipe/multifactorauth/index.d.ts
diff --git a/lib/build/recipe/multifactorauth/types.d.ts b/lib/build/recipe/multifactorauth/types.d.ts
diff --git a/lib/build/recipe/passwordless/components/features/mfa/index.d.ts b/lib/build/recipe/passwordless/components/features/mfa/index.d.ts
diff --git a/lib/build/thirdpartypasswordless.js b/lib/build/thirdpartypasswordless.js
diff --git a/lib/ts/components/assets/otpIcon.tsx b/lib/ts/components/assets/otpIcon.tsx
diff --git a/lib/ts/recipe/multifactorauth/recipe.tsx b/lib/ts/recipe/multifactorauth/recipe.tsx
@@ -135,7 +135,9 @@ export default class MultiFactorAuth extends RecipeModule<
         } else if (context.action === "GO_TO_FACTOR") {
             const redirectInfo = this.getSecondaryFactors().find((f) => f.id === context.factorId);
             if (redirectInfo !== undefined) {
-                return this.config.appInfo.websiteBasePath.appendPath(redirectInfo.path).getAsStringDangerous();
+                return this.config.appInfo.websiteBasePath
+                    .appendPath(new NormalisedURLPath(redirectInfo.path))
+                    .getAsStringDangerous();
             }
             throw new Error("Requested redirect to unknown factor id");
         } else {

diff --git a/lib/ts/recipe/multifactorauth/types.ts b/lib/ts/recipe/multifactorauth/types.ts
@@ -22,7 +22,6 @@ import type {
 } from "../recipeModule/types";
 import type { FC } from "react";
 import type { OverrideableBuilder } from "supertokens-js-override";
-import type NormalisedURLPath from "supertokens-web-js/lib/build/normalisedURLPath";
 import type { RecipeInterface } from "supertokens-web-js/recipe/multifactorauth";
 import type { MFAFactorInfo } from "supertokens-web-js/recipe/multifactorauth/types";
 
@@ -81,10 +80,7 @@ export type PreAPIHookContext = {
     userContext: any;
 };
 
-export type OnHandleEventContext = {
-    action: "FACTOR_CHOSEN";
-    userContext: any;
-};
+export type OnHandleEventContext = never;
 
 export type FactorChooserThemeProps = {
     mfaInfo: MFAFactorInfo;
@@ -102,5 +98,5 @@ export type SecondaryFactorRedirectionInfo = {
     name: string;
     description: string;
     logo: FC;
-    path: NormalisedURLPath;
+    path: string;
 };