feat: fix UI review comments

supertokens · May 2, 2024 · 045d01f · 045d01f
1 parent 9178b17
commit 045d01f
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 8 deletions.
diff --git a/lib/build/passwordlessprebuiltui.js b/lib/build/passwordlessprebuiltui.js
diff --git a/lib/build/recipe/passwordless/components/themes/translations.d.ts b/lib/build/recipe/passwordless/components/themes/translations.d.ts
diff --git a/lib/ts/recipe/passwordless/components/features/signInAndUpEPCombo/index.tsx b/lib/ts/recipe/passwordless/components/features/signInAndUpEPCombo/index.tsx
@@ -65,6 +65,7 @@ export function useChildProps(
             setIsPhoneNumber: (isPhone) => {
                 if (isPhone && showPasswordField) {
                     setShowPasswordField(false);
+                    setShowContinueWithPasswordlessLink(false);
                 }
                 setIsPhoneNumber(isPhone);
             },

diff --git a/lib/ts/recipe/passwordless/components/themes/continueWithPasswordless/index.tsx b/lib/ts/recipe/passwordless/components/themes/continueWithPasswordless/index.tsx
@@ -35,7 +35,7 @@ const ContinueWithPasswordless: React.FC<{ continueWithPasswordlessClicked: () =
                     props.continueWithPasswordlessClicked();
                 }}
                 type="button"
-                label={"PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS"}
+                label={"PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS_BUTTON"}
             />
         </div>
     );

diff --git a/.../recipe/passwordless/components/themes/signInUpEPCombo/continueWithPasswordlessFooter.tsx b/.../recipe/passwordless/components/themes/signInUpEPCombo/continueWithPasswordlessFooter.tsx
@@ -45,7 +45,7 @@ export const ContinueWithPasswordlessFooter: React.FC<{
                     return onContinueWithPasswordlessClick(email);
                 }
             }}>
-            {t("PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS")}
+            {t("PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS_LINK")}
         </a>
     );
 };
diff --git a/lib/ts/recipe/passwordless/components/themes/translations.ts b/lib/ts/recipe/passwordless/components/themes/translations.ts
@@ -27,7 +27,8 @@ export const defaultTranslationsPasswordless = {
         PWLESS_SIGN_IN_UP_SWITCH_TO_PHONE: "Use a Phone number",
         PWLESS_SIGN_IN_UP_SWITCH_TO_EMAIL: "Use an Email",
         PWLESS_SIGN_IN_UP_CONTINUE_BUTTON: "CONTINUE",
-        PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS: "Continue with passwordless",
+        PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS_LINK: "Continue with passwordless",
+        PWLESS_COMBO_CONTINUE_WITH_PASSWORDLESS_BUTTON: "CONTINUE WITH PASSWORDLESS",
 
         PWLESS_COMBO_PASSWORD_LABEL: "Password",
         PWLESS_COMBO_FORGOT_PW_LINK: "Forgot password?",

diff --git a/stories/allrecipes.stories.tsx b/stories/allrecipes.stories.tsx
@@ -98,7 +98,7 @@ export const SignUpPasswordless: Story = {
         // Assigns canvas to the component root element
         const canvas = within(canvasElement);
 
-        const switcher = await canvas.findByText("Continue with passwordless");
+        const switcher = await canvas.findByText("CONTINUE WITH PASSWORDLESS");
         await new Promise((res) => setTimeout(res, 100));
         canvasElement;
         await userEvent.click(switcher, { delay: 200 });