fix: formfields should be camelcase for /{apiBasePath}/<tenantId>/user/password/reset #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds instead). This broke codegen why trying to generate directly from the spec deployed on swaggerhub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke codegen when generating from version FDI 1.19.0 on swaggerhub (target of typescript-fetch). However, it appears it breaks in all of the codegens when you use the API directly (verified in 3.0.0 as well).
This was tested with core 9.0.2 and supertokens-node 17 / 18. It appears the code that reads this field has not changed though, as its identical in the latest version (see https://github.com/supertokens/supertokens-node/blob/master/lib/build/recipe/emailpassword/api/passwordReset.js#L37).
Basically, codegen would forward this as
formfieldsinstead offormFields, which in turn caused thevalidateFormFieldsOrThrowErrorasrequestBody.formFieldswould be undefined.I am unsure if these are codegened from something else, if it is let me know and I will open a PR in the proper location.