-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cli/react multitenancy #131
base: master
Are you sure you want to change the base?
Conversation
Hey! So I have this basically ready to rock. One small problem — I changed the name of the folder Running
Running locally with
Do you have any insight from changing the folder name in the previous react upgrade? |
2f31568
to
55364fb
Compare
<a href="/auth" className="sessionButton"> | ||
Sign-up / Login | ||
</a> | ||
<a href="/dashboard" className="sessionButton"> | ||
Dashboard | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inconsitent with the latest changes in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I missed a couple things from the refactor and didn't realize. I pushed up a change for this but I need to re-fix the css and move some logic around to match. I'll get this done today or tomorrow
if (context.action === "SUCCESS" && context.newSessionCreated) { | ||
return "/dashboard"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inconsistent with the latest changes in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Summary of change
Updates React multitenancy upgrades to be boilerplate
Test plan
--recipe=...
for example)--recipe=...
for example)Checklist for important updates
package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
Recipe
andallRecipes
SupportedFrontends
andallFrontends
if requiredSupportedBackends
andallBackends
if requiredRemaining TODOs for this PR