chrome extension open to new page #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while onboarding if click to chrome extension it movers out of onboarding flow that's why it needs to open in a new tab
🔍 Code Review Summary✅ All Clear: This commit looks good! 👍 Overview
Useful Commands
|
![kaizen-bot[bot]](https://avatars.githubusercontent.com/in/480502?s=60&v=4){kind=small}
| @@ -147,7 +147,7 @@ function StepOne({ currStep }: { currStep: number }) { | |||
| <ol className="text-lg space-y-3"> | |||
| <li> | |||
| Download the chrome extension{" "} | |||
| <a className="underline underline-offset-2" href="/extension"> | |||
There was a problem hiding this comment.
Comment: Missing rel attribute for external links
Solution: Add rel='noopener noreferrer' to the anchor tag.
Suggested change
| <a className="underline underline-offset-2" href="/extension"> | |
| <a className="underline underline-offset-2" href="/extension" target="_blank" rel="noopener noreferrer"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding Page Update
Update the onboarding page to improve the user experience.
The changes will provide a better user experience by opening the extension download link in a new tab, keeping the user on the onboarding page.
Original Description