Fix ground types 'hills' & 'canyon' not using seed #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where the ground types of 'hills' and 'canyon' were not using the seed. Based on issue #44, it seems that the intention was to use the seed to keep the layout consistent similar to the other ground types, 'noise' and 'spikes'. Below is an explanation of the steps I took to fix the issue:
perlin
object in theupdateGround
functionperlin.noise
method.randomWithSeed
that will be used in the for loop to generate random numbers using the seed.random
function defined earlier in the coder.random(666)
with the newrandomWithSeed
variabler
variable is no longer used, I simplified the function by removing it as a parameter and as well as the lineif (r == undefined) r = Math;
, which isn't needed.seed
as a parameter so we can pull in the user's custom seed when generating therandomWithSeed
number.Fixes Issues