[STTNHUB-312] fix: Link Planning item updates to content

server/features/ingest_planning.feature

@@ -123,7 +123,7 @@ Feature: Ingest STT Planning items
         Then we get list with 1 items
         """
         {"_items": [{
-            "uri": "urn:newsml:stt.fi:20171219:101801633",
+            "uri": "urn:newsml:stt.fi:101801633",
             "assignment_id": "__no_value__",
             "priority": 6,
             "task": {
@@ -175,7 +175,7 @@ Feature: Ingest STT Planning items
         Then we get list with 1 items
         """
         {"_items": [{
-            "uri": "urn:newsml:stt.fi:20171219:101801633",
+            "uri": "urn:newsml:stt.fi:101801633",
             "assignment_id": "#assignment._id#"
         }]}
         """
@@ -243,7 +243,7 @@ Feature: Ingest STT Planning items
         Then we get list with 1 items
         """
         {"_items": [{
-            "uri": "urn:newsml:stt.fi:20171219:101801633",
+            "uri": "urn:newsml:stt.fi:101801633",
             "assignment_id": "#assignment._id#"
         }]}
         """
@@ -327,3 +327,81 @@ Feature: Ingest STT Planning items
             }
         }]}
         """
+
+    @auth
+    @stt_cvs
+    @stt_providers
+    Scenario: Link ingested coverages to content on update
+        # Ingest Planning with 0 coverages (1 placeholder)
+        When we fetch from "STTPlanningML" ingest "planning_ml_before_link_content.xml"
+        When we get "/planning"
+        Then we get list with 1 items
+        """
+        {"_items": [{
+            "_id": "urn:newsml:stt.fi:437036",
+            "coverages": [{
+                "assigned_to": "__empty__",
+                "flags": {"placeholder": true}
+            }]
+        }]}
+        """
+        When we get "/assignments"
+        Then we get list with 0 items
+        # Ingest content
+        When we fetch from "STTNewsML" ingest "stt_newsml_link_content.xml" using routing_scheme
+        """
+        #routing_schemes._id#
+        """
+        When we get "published"
+        Then we get list with 1 items
+        """
+        {"_items": [{
+            "uri": "urn:newsml:stt.fi:101801633",
+            "assignment_id": "__no_value__"
+        }]}
+        """
+        When we get "/assignments"
+        Then we get list with 0 items
+        When we fetch from "STTPlanningML" ingest "planning_ml_link_content.xml"
+        When we get "/assignments"
+        Then we get list with 1 items
+        """
+        {"_items": [{
+            "planning_item": "urn:newsml:stt.fi:437036",
+            "coverage_item": "ID_TEXT_120123822",
+            "priority": 6,
+            "assigned_to": {
+                "desk": "#desks._id#",
+                "state": "completed"
+            }
+        }]}
+        """
+        Then we store "assignment" with first item
+        When we get "/planning"
+        Then we get list with 1 items
+        """
+        {"_items": [{
+            "_id": "urn:newsml:stt.fi:437036",
+            "coverages": [{
+                "coverage_id": "ID_TEXT_120123822",
+                "assigned_to": {
+                    "assignment_id": "#assignment._id#",
+                    "desk": "#desks._id#",
+                    "user": null,
+                    "state": "completed",
+                    "priority": 6
+                }
+            }],
+            "extra": {
+                "stt_topics": "437036"
+            }
+        }]}
+        """
+        When we get "published"
+        Then we get list with 1 items
+        """
+        {"_items": [{
+            "uri": "urn:newsml:stt.fi:101801633",
+            "assignment_id": "#assignment._id#"
+        }]}
+        """

server/stt/common.py

@@ -43,6 +43,10 @@ def remove_date_portion_from_id(item_id: str) -> str:
     if len(id_parts) == 5:
         # Correct format to split, Remove the date portion of the ID
         del id_parts[3]
+    elif len(id_parts) == 6:
+        # ID includes version, remove the date and version portions of the ID
+        del id_parts[5]
+        del id_parts[3]
 
     return ":".join(id_parts)
 

server/stt/parser.py

@@ -3,6 +3,8 @@
 from superdesk.io.registry import register_feed_parser
 from superdesk.io.feed_parsers.stt_newsml import STTNewsMLFeedParser, STT_LOCATION_MAP
 
+from .common import remove_date_portion_from_id
+
 
 NA = 'N/A'
 
@@ -71,6 +73,7 @@ def set_extra_fields(self, item, xml):
         # newsItem guid
         if 'uri' in item:
             item.setdefault('extra', {})['newsItem_guid'] = item['uri']
+            item["uri"] = remove_date_portion_from_id(item["uri"])
 
         # newsItem altId
         try:

server/stt/signal_hooks.py

@@ -7,10 +7,9 @@
 
 from superdesk import get_resource_service, signals
 from superdesk.factory.app import SuperdeskEve
-from superdesk.metadata.item import ITEM_STATE, CONTENT_STATE
 
 from planning.common import WORKFLOW_STATE, ASSIGNMENT_WORKFLOW_STATE
-from planning.signals import planning_created
+from planning.signals import planning_ingested
 
 from stt.stt_planning_ml import STTPlanningMLParser
 
@@ -19,48 +18,86 @@
 
 
 def init_app(_app: SuperdeskEve):
-    planning_created.connect(after_planning_created)
+    planning_ingested.connect(link_coverages_to_content)
     signals.item_publish.connect(before_content_published)
 
 
-def after_planning_created(_sender: Any, item: Dict[str, Any]):
+def link_coverages_to_content(_sender: Any, item: Dict[str, Any], original: Optional[Dict[str, Any]] = None):
     """Link coverage(s) to content upon ingest (if content exists)"""
 
+    try:
+        planning_id = item[config.ID_FIELD]
+    except KeyError:
+        logger.error("Failed to link planning with content, _id is missing")
+        return
+
+    if not len(item.get("coverages") or []):
+        # No coverages on this Planning item, no need to continue
+        return
+
+    try:
+        if len(item["coverages"]) == 1 and item["coverages"][0]["flags"]["placeholder"] is True:
+            # There is only 1 coverage, and it is a placeholder coverage, no need to continue
+            return
+    except (KeyError, IndexError, TypeError):
+        return
+
     if not _is_ingested_by_stt_planning_ml(item):
         return
 
+    updates = {"coverages": deepcopy(item["coverages"])}
+    coverage_id_to_content_id_map: Dict[str, str] = {}
     delivery_service = get_resource_service("delivery")
-    planning_id = item.get(config.ID_FIELD)
-    updates = {"coverages": deepcopy(item.get("coverages") or [])}
-    coverages_updated = {}
+    planning_service = get_resource_service("planning")
     for coverage in updates["coverages"]:
-        coverage_id = coverage.get("coverage_id")
-        deliveries = delivery_service.get(req=None, lookup={
+        try:
+            coverage_id = coverage["coverage_id"]
+        except KeyError:
+            logger.error("Failed to link coverage with content, coverage_id is missing")
+            continue
+
+        try:
+            if coverage["flags"]["placeholder"] is True:
+                # This is a placeholder coverage, and will never be attached to content
+                continue
+        except (KeyError, TypeError):
+            pass
+
+        # Get the deliveries that aren't linked to an Assignment
+        # These deliveries are added in ``STTPlanningMLParser._create_temp_assignment_deliveries``
+        deliveries = delivery_service.get_from_mongo(req=None, lookup={
             "planning_id": planning_id,
             "coverage_id": coverage_id,
-        })
-        content = _get_content_item_by_uris([
-            delivery["item_id"]
-            for delivery in deliveries
-            if delivery.get("item_id") is not None
-        ])
+            "assignment_id": None,
+            "item_id": {"$ne": None}},
+        )
+        if not deliveries.count():
+            # No unlinked deliveries found for this Coverage
+            continue
+
+        content = _get_content_item_by_uris([delivery["item_id"] for delivery in deliveries])
         if content is None:
             # No content has been found
             # Linking will occur when content is published (see ``before_content_published``)
             continue
 
         _update_coverage_assignment_details(coverage, content)
-        coverages_updated[coverage_id] = content
+        coverage_id_to_content_id_map[coverage_id] = content[config.ID_FIELD]
 
-    updated_item = get_resource_service("planning").patch(planning_id, updates)
-    updated_coverage_ids = coverages_updated.keys()
+    updated_coverage_ids = coverage_id_to_content_id_map.keys()
+    if not len(updated_coverage_ids):
+        # No coverages were updated, no need to update the Planning item or link any content
+        return
+
+    # Update the planning item with the latest Assignment information, and link the coverages to the content
+    updated_item = planning_service.patch(planning_id, updates)
     for coverage in updated_item.get("coverages") or []:
         coverage_id = coverage.get("coverage_id")
         assignment_id = (coverage.get("assigned_to") or {}).get("assignment_id")
         if coverage_id not in updated_coverage_ids or assignment_id is None:
             continue
 
-        _link_assignment_and_content(assignment_id, coverage_id, coverages_updated[coverage_id]["_id"])
+        _link_assignment_and_content(assignment_id, coverage_id, coverage_id_to_content_id_map[coverage_id])
 
 
 def before_content_published(_sender: Any, item: Dict[str, Any], updates: Dict[str, Any]):
@@ -110,18 +147,24 @@ def before_content_published(_sender: Any, item: Dict[str, Any], updates: Dict[s
 
 
 def _is_ingested_by_stt_planning_ml(item: Dict[str, Any]) -> bool:
-    """Determine if the item was ingested by the STTPlanningMLParser parser"""
-
-    ingest_provider_id = item.get("ingest_provider")
-    if item.get(ITEM_STATE) != CONTENT_STATE.INGESTED or ingest_provider_id is None:
+    """Determine if the item was ingested by the ``STTPlanningMLParser`` parser"""
+
+    try:
+        if item["ingest_provider"] is None:
+            return False
+        ingest_provider_id = ObjectId(item["ingest_provider"])
+        ingest_provider = get_resource_service("ingest_providers").find_one(req=None, _id=ingest_provider_id)
+        return ingest_provider["feed_parser"] == STTPlanningMLParser.NAME
+    except (KeyError, TypeError):
         return False
 
-    ingest_provider = get_resource_service("ingest_providers").find_one(req=None, _id=ObjectId(ingest_provider_id))
-    return ingest_provider is not None and ingest_provider.get("feed_parser") == STTPlanningMLParser.NAME
-
 
 def _get_content_item_by_uris(uris: List[str]) -> Optional[Dict[str, Any]]:
-    """Get content item(s) by uri"""
+    """Get latest content item by uri"""
+
+    if not len(uris):
+        # No URIs were provided, so there
+        return None
 
     req = ParsedRequest()
     req.args = {
@@ -158,8 +201,12 @@ def _update_coverage_assignment_details(coverage: Dict[str, Any], content: Dict[
     })
 
 
-def _link_assignment_and_content(assignment_id: ObjectId, coverage_id: str, content_id: str,
-                                 skip_archive_update: Optional[bool] = False):
+def _link_assignment_and_content(
+    assignment_id: ObjectId,
+    coverage_id: str,
+    content_id: str,
+    skip_archive_update: Optional[bool] = False
+):
     """Remove all temporary delivery entries for this coverage and link assignment and content"""
 
     get_resource_service("delivery").delete_action(lookup={"coverage_id": coverage_id})

server/stt/stt_planning_ml.py

@@ -123,7 +123,7 @@ def _create_temp_assignment_deliveries(
                     {
                         "planning_id": planning_id,
                         "coverage_id": coverage_id,
-                        "item_id": content_guid,
+                        "item_id": remove_date_portion_from_id(content_guid),
                     }
                 )
 

server/tests/fixtures/planning_ml_before_link_content.xml

@@ -0,0 +1,38 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<planningItem
+    xmlns="http://iptc.org/std/nar/2006-10-01/"
+    xmlns:stt="http://www.stt-lehtikuva.fi/NewsML"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://iptc.org/std/nar/2006-10-01/ http://www.iptc.org/std/NewsML-G2/2.12/specification/NewsML-G2_2.12-spec-All-Power.xsd http://www.stt-lehtikuva.fi/NewsML http://www.stt-lehtikuva.fi/newsml/schema/STT-Lehtikuva_NewsML_G2.xsd"
+    guid="urn:newsml:stt.fi:20220330:437036"
+    version="1"
+    standard="NewsML-G2"
+    standardversion="2.12"
+    conformance="power"
+    xml:lang="fi"
+>
+    <catalogRef href="http://www.iptc.org/std/catalog/catalog.IPTC-G2-Standards_18.xml"/>
+    <catalogRef href="http://www.stt-lehtikuva.fi/newsml/doc/stt-NewsCodesCatalog_1.xml"/>
+    <itemMeta>
+        <itemClass qcode="plinat:newscoverage"/>
+        <provider literal="STT"/>
+        <versionCreated>2022-03-22T12:54:59+02:00</versionCreated>
+        <pubStatus qcode="stat:usable"/>
+        <edNote role="sttdescription:additionalinfo">Miten taistelut etenevät? Millaisia kansainvälisiä reaktioita syntyy? Entä miten tilanne Venäjällä elää? Seuraamme päivän tapahtumia ja tarkennamme paketointia.</edNote>
+    </itemMeta>
+    <contentMeta>
+        <contentCreated>2022-03-22T14:54:59+02:00</contentCreated>
+        <contentModified>2022-03-22T14:54:59+02:00</contentModified>
+        <headline>Miten tilanne Ukrainan sodan ympärillä ja Ukrainassa kehittyy?</headline>
+        <description role="drol:summary"/>
+        <subject qcode="stt-topics:437036">
+            <related rel="sttrel:assigneddate" value="2022-03-30" valuedatatype="Date"/>
+        </subject>
+        <subject type="cpnat:department" qcode="sttdepartment:14">
+            <name>Ulkomaat</name>
+        </subject>
+    </contentMeta>
+    <assert qcode="stt-topics:437036">
+        <newsCoverageStatus qcode="ncostat:int"/>
+    </assert>
+</planningItem>