Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-7470] - Create new async Agenda resource, service & REST API #2172

Merged
merged 9 commits into from
Jan 9, 2025
Merged

[SDESK-7470] - Create new async Agenda resource, service & REST API #2172

merged 9 commits into from
Jan 9, 2025

Conversation

BrianMwangi21
Copy link

Purpose

This PR creates new async agenda resource and service and exposes their rest API:

  • Implementing a new resource model for agendas
  • Implementing new async resource service for agenda
  • Implementing resource config for agenda and register it in planning module
  • Disable the API in old agenda resource

Solves: SDESK-7470

@BrianMwangi21 BrianMwangi21 added this to the 3.0 milestone Jan 7, 2025
MarkLark86
MarkLark86 reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small things

server/planning/agendas_async/agendas_async_service.py Outdated Show resolved Hide resolved
server/planning/agendas_async/agendas_async_service.py Outdated Show resolved Hide resolved
server/planning/agendas_async/agendas_async_service.py Outdated Show resolved Hide resolved
eos87
eos87 reviewed Jan 8, 2025
View reviewed changes
Copy link

@eos87 eos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments

server/planning/agendas_async/agendas_async_service.py Outdated Show resolved Hide resolved
server/planning/agendas_async/agendas_async_service.py Show resolved Hide resolved
server/planning/types/agendas.py Outdated Show resolved Hide resolved
@BrianMwangi21 BrianMwangi21 requested a review from eos87 January 9, 2025 08:29
@BrianMwangi21 BrianMwangi21 merged commit f7d2619 into superdesk:async Jan 9, 2025
4 of 10 checks passed
@BrianMwangi21 BrianMwangi21 mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

@eos87 eos87 Awaiting requested review from eos87

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianMwangi21 @eos87 @MarkLark86