-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDESK-7462] - Events, Planning & History resource, service and REST API #2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be good if you can add types to function signatures, which enables type checking by mypy and autocomplete/error checking from within IDs
Good job @BrianMwangi21 Just a few small things |
There are mypy/type errors, please check those out as well |
c7cf659
to
f978459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple improvements to the types. Please check wherever you're using just Any
and replace with dict[str, Any]
, so type checking/IDE knows the type of the variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Purpose
This PR creates new async events and planning history resources and services and exposes their rest API by :
Solves: SDESK-7462