Subject field #2158
Subject field #2158
Conversation
| subject: allSubjects.map(({qcode, name, parent}) => { | ||
| var itemToStore: IStorageFormat = {qcode, name, parent}; | ||
|
|
||
| if (parent != null) { |
There was a problem hiding this comment.
When would this condition make a difference?
const a = {x: 1}
const b = {...a}
if (b.x != null) { // <-- would never make a difference because if a.x and b.x are the same
b.x = a.x;
}
There was a problem hiding this comment.
Doesn't, I had it copied over from the subject in client-core
|
|
||
| return itemToStore; | ||
| }), | ||
| subject: allSubjects, |
There was a problem hiding this comment.
allSubjects is confusing naming, because if you filter it, you can't call it "all" anymore
| @@ -36,12 +36,12 @@ export function getSubjectField(): IFieldDefinition { | |||
| return (item.subject ?? []).map(({qcode}) => qcode); | |||
| }, | |||
| storeValue: (item, operationalValue: Array<ISubjectCode['qcode']>) => { | |||
| const allSubjects: Array<ISubjectCode> = (planningApi.redux.store.getState().subjects ?? []) | |||
| const filteredSubjects: Array<ISubjectCode> = (planningApi.redux.store.getState().subjects ?? []) | |||
There was a problem hiding this comment.
filteredSubjects isn't much better. It doesn't make sense to mention programming operations (filter,map,reduce etc.) that you performed - but what is being achieved by those programming operations. When it's something small and obvious like here I'd call it subjects simply without elaborating. If you wanted more details, then maybe subjectsFull since the purpose of the operation is to return full objects instead of qcodes only.
thecalcc
merged commit 680c4ae
into
superdesk:authoring-react-planning
STT-63
Front-end checklist
memoorPureComponentto define new React components (and updates existing usages in modified code segments)lodash.getwith optional chaining and nullish coalescing for modified code segmentssuperdeskApi)superdesk-ui-frameworkandsuperdeskApiwhen possible instead of using ones defined in this repository.planningApiwhere it is possible to usesuperdeskApiplanningApi)