Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Some coverage items are not displaying in Newspro [SDCP-755] #1940

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix : Some coverage items are not displaying in Newspro [SDCP-755] #1940

merged 3 commits into from
Apr 2, 2024

Conversation

devketanpro
Copy link
Member

No description provided.

@devketanpro devketanpro requested a review from petrjasek April 1, 2024 17:19
@petrjasek petrjasek added this to the 2.6.3 milestone Apr 2, 2024
@devketanpro devketanpro changed the title Fix : Some coverage items are not displaying in Newspro [CPCN-726] Fix : Some coverage items are not displaying in Newspro [SDCP-755] Apr 2, 2024
@devketanpro devketanpro requested a review from petrjasek April 2, 2024 10:00
@devketanpro devketanpro merged commit 938f153 into superdesk:develop Apr 2, 2024
15 checks passed
@devketanpro devketanpro deleted the CPCN-726 branch April 2, 2024 10:50
devketanpro added a commit that referenced this pull request Apr 2, 2024
@devketanpro
Fix : Some coverage items are not displaying in Newspro [SDCP-755] (#…
cdac148 
…1940)

* FIX : if planning item is locked when working on coverage assignment[CPCN-726]

* remove all functionality related to check planning is locked

* remove unwanted code
@MarkLark86
Copy link
Collaborator

@petrjasek @devketanpro Does this cause any issues for the person that had the Planning item locked in the first place?
i.e.

  1. [UserA] Create a Planning item with a text Coverage
  2. [UserA] Add the text Coverage to Workflow
  3. [UserA] Make changes to the Planning and Coverage metadata (DO NOT SAVE)
  4. [UserB] Create a Text Content item
  5. [UserB] Link Text Content to Assignment (via the Fulfil Assignment action in monitoring)
  6. [UserA] Save the Planning item

Question: Are the changes UserA made to the Planning & Coverage kept? Does the Planning Editor update with the changes from the linking to Assignment, is are these changes kept or lost? I believe this is why that lock checking was added in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@devketanpro @MarkLark86 @petrjasek