Authoring react post broadcasting #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no request
* [STTNHUB-312] Add planning_ingested signal * fix behave tests * fix(e2e): Use chrome in CI to run tests (#1891)
…ssignment after making content profiles mandatory, DEFAULT_SCHEMA no longer exists
* add assigned user/desk info to planning json CPCN-502
…1892) * Config: Add new config for Event to Planning sync * ui: Send `embedded_planning` from front-end * api: Improve Planning ContentProfiles module and types * api: Process `embedded_planning` and sync metadata * fix(ui): Failed to get lock for recurring series * fix(ui): Improve EmbeddedCoverageForm UI * fix(ui): Event to Planning translations copies fields multiple times * fix(e2e): Use chrome in CI to run tests * Add behave tests for embedded planning * Add behave tests for multilingual embedded planning * Add CVs to behave test * fix: Coverage Planning updated when processing Assignment details Embedded/Sync wasn't working once above bug was fixed * Add behave tests for event metadata sync
|
@petrjasek can you check the backend issue and review this? |
|
what backend issue @tomaskikutis ? |
|
some pytest cases were failing, but when I restarted, they passed! |
|
yep, I was referring to nose tests failing |
petrjasek
approved these changes
Jan 31, 2024
|
but seems like this wouldn't build still: ERROR in ../planning/node_modules/redux/dist/redux.legacy-esm.js
Module parse failed: Unexpected token (376:6)
You may need an appropriate loader to handle this file type.
| dispatch = compose(...chain)(store.dispatch);
| return {
| ...store,
| dispatch
| };
@ ../planning/client/utils/index.ts 53:14-30
@ ../planning/client/controllers/FulfilAssignmentController.tsx
@ ../planning/client/controllers/index.ts
@ ../planning/index.ts
@ ./dist/app-importer.generated.js
@ ./node_modules/superdesk-core/scripts/index.ts
@ multi ./node_modules/superdesk-core/scripts/index |
|
did you regenerate package lock from scratch @petrjasek ? Pytest is failing again now |
|
I was just getting local changes due to different hash, but also wanted to trigger a rebuild. found the build issue at the end which was fireq specific |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes unit/e2e tests and also updates usages of superdesk-api and other imports