Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assignment article preview to support multilingual features [SDESK-7061] #1876

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Update Assignment article preview to support multilingual features [SDESK-7061] #1876

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c1896e
update assignment preview to support multilngual fields data
devketanpro Nov 8, 2023
07797ec
remove unwanted print
devketanpro Nov 8, 2023
7a0b689
minor change
devketanpro Nov 8, 2023
53d86d2
fix flake8
devketanpro Nov 8, 2023
3a8dee7
handle translated name and headline both
devketanpro Nov 8, 2023
3793ea1
refactore code
devketanpro Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion server/planning/planning/planning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,28 @@ def _create_update_assignment(
coverage_status = updates.get("workflow_status", original.get("workflow_status"))
is_coverage_draft = coverage_status == WORKFLOW_STATE.DRAFT

translations = planning.get("translations")
translated_value = {}
translated_name = ""
if translations is not None:
translated_value.update(
{
entry["field"]: entry["value"]
for entry in translations or []
if entry["language"] == doc.get("planning", {}).get("language")
}
)

translated_name = translated_value.get("name", translated_value.get("headline"))
MarkLark86 marked this conversation as resolved.
Show resolved Hide resolved

doc["planning"].update(
{
key: val
for key, val in translated_value.items()
if key in ("ednote", "description_text", "headline", "slugline", "authors", "internal_note")
}
)

if not assigned_to.get("assignment_id") and (assigned_to.get("user") or assigned_to.get("desk")):
# Creating a new assignment
assign_state = ASSIGNMENT_WORKFLOW_STATE.DRAFT if is_coverage_draft else ASSIGNMENT_WORKFLOW_STATE.ASSIGNED
Expand All @@ -743,6 +765,9 @@ def _create_update_assignment(
if assigned_to.get("state") and assigned_to["state"] != ASSIGNMENT_WORKFLOW_STATE.DRAFT:
assign_state = assigned_to.get("state")

if translated_value and translated_name and "headline" not in doc["planning"]:
doc["planning"]["headline"] = translated_name

assignment = {
"assigned_to": {
"user": assigned_to.get("user"),
Expand All @@ -756,6 +781,8 @@ def _create_update_assignment(
"priority": assigned_to.get("priority", DEFAULT_ASSIGNMENT_PRIORITY),
"description_text": planning.get("description_text"),
}
if translated_value and translated_name and assignment.get("name") != translated_value.get("name"):
assignment["name"] = translated_name

if doc.get("scheduled_update_id"):
assignment["scheduled_update_id"] = doc["scheduled_update_id"]
Expand Down Expand Up @@ -846,7 +873,7 @@ def _create_update_assignment(

# If the Planning name has been changed
if planning_original.get("name") != planning_updates.get("name"):
assignment["name"] = planning["name"]
assignment["name"] = planning["name"] if not translated_value and translated_name else translated_name

# If there has been a change in the planning internal note then notify the assigned users/desk
if planning_updates.get("internal_note") and planning_original.get("internal_note") != planning_updates.get(
Expand Down
Loading