Fix authoring and field #4697
Fix authoring and field #4697
Conversation
| @@ -23,8 +23,10 @@ export const setupAuthoringReact = (url: string) => { | |||
| (extensionUrl) => extensionUrl.startsWith(trimStartExact(parsedPath.hash, '#')), | |||
| ) != null; | |||
|
|
|||
| const isNavToPlan = parsedPath.hash.startsWith('#/planning'); | |||
There was a problem hiding this comment.
isNavigatingToPlanning would fit on the line too, wouldn't it? :)
| @@ -123,7 +123,7 @@ | |||
| "sass-loader": "6.0.6", | |||
| "shortid": "2.2.8", | |||
| "style-loader": "0.20.2", | |||
| "superdesk-ui-framework": "4.0.3", | |||
| "superdesk-ui-framework": "^4.0.4", | |||
There was a problem hiding this comment.
imo would be better to avoid ^ there, we had changes in hotfix version which broke builds, the idea to remove that was that we get the updated framework version tested before it's used by clients
cc @tomaskikutis
There was a problem hiding this comment.
You might have replied about it before, but I forgot - why package-lock isn't enough for hotfixes?
There was a problem hiding this comment.
it will start breaking builds in superdesk repo but not in superdesk-client-core when there is a change that requires changes in core
There was a problem hiding this comment.
why would it break builds in main superdesk repo? It also has package-lock
There was a problem hiding this comment.
or you say that when client-core is being updated from root repo it would update the version then?
There was a problem hiding this comment.
dependabot will update ui framework and the build will fail, but it won't be visible on client-core repo but rather on some superdesk-cp where we would be using an older version, but which none of the ui team is following
There was a problem hiding this comment.
I've added a grep-lint rule for this #4710
STT-109